Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2225843002:
[test] Split TurboFan mjsunit expectations for variants. (Closed)
|
Created:
4 years, 4 months ago by Michael Starzinger Modified:
4 years, 4 months ago Reviewers:
Michael Achenbach CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Split TurboFan mjsunit expectations for variants.
R=machenbach@chromium.org
Committed: https://crrev.com/5eed70c6b474635ccdf111e2269dbf33e629ce0b
Committed: https://crrev.com/025ddb21efec84fdac3d7e28a301e620571cd933
Cr-Original-Commit-Position: refs/heads/master@{#38445}
Cr-Commit-Position: refs/heads/master@{#38452}
Patch Set 1 #Patch Set 2 : Small fix. #
Total comments: 2
Patch Set 3 : Addressed comment. #Patch Set 4 : Small fix. #Patch Set 5 : More fixes. #Patch Set 6 : One more skip. #Messages
Total messages: 37 (25 generated)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm with comment https://codereview.chromium.org/2225843002/diff/20001/test/mjsunit/mjsunit.st... File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/2225843002/diff/20001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:64: 'ignition/regress-599001-verifyheap': [PASS, NO_VARIANTS], How about moving those instead to the stress variant block below, with SKIP?
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks. Comment addressed. Landing soon. https://codereview.chromium.org/2225843002/diff/20001/test/mjsunit/mjsunit.st... File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/2225843002/diff/20001/test/mjsunit/mjsunit.st... test/mjsunit/mjsunit.status:64: 'ignition/regress-599001-verifyheap': [PASS, NO_VARIANTS], On 2016/08/08 12:46:05, Michael Achenbach wrote: > How about moving those instead to the stress variant block below, with SKIP? Done.
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mstarzinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [test] Split TurboFan mjsunit expectations for variants. R=machenbach@chromium.org ========== to ========== [test] Split TurboFan mjsunit expectations for variants. R=machenbach@chromium.org Committed: https://crrev.com/5eed70c6b474635ccdf111e2269dbf33e629ce0b Cr-Commit-Position: refs/heads/master@{#38445} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/5eed70c6b474635ccdf111e2269dbf33e629ce0b Cr-Commit-Position: refs/heads/master@{#38445}
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2227733002/ by machenbach@chromium.org. The reason for reverting is: Revert as asan bot blocks the clusterfuzz uploads: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/14256 https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN Please add more skips on reland..
Message was sent while issue was closed.
Description was changed from ========== [test] Split TurboFan mjsunit expectations for variants. R=machenbach@chromium.org Committed: https://crrev.com/5eed70c6b474635ccdf111e2269dbf33e629ce0b Cr-Commit-Position: refs/heads/master@{#38445} ========== to ========== [test] Split TurboFan mjsunit expectations for variants. R=machenbach@chromium.org Committed: https://crrev.com/5eed70c6b474635ccdf111e2269dbf33e629ce0b Cr-Commit-Position: refs/heads/master@{#38445} ==========
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mstarzinger@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/2225843002/#ps100001 (title: "One more skip.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [test] Split TurboFan mjsunit expectations for variants. R=machenbach@chromium.org Committed: https://crrev.com/5eed70c6b474635ccdf111e2269dbf33e629ce0b Cr-Commit-Position: refs/heads/master@{#38445} ========== to ========== [test] Split TurboFan mjsunit expectations for variants. R=machenbach@chromium.org Committed: https://crrev.com/5eed70c6b474635ccdf111e2269dbf33e629ce0b Cr-Commit-Position: refs/heads/master@{#38445} ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [test] Split TurboFan mjsunit expectations for variants. R=machenbach@chromium.org Committed: https://crrev.com/5eed70c6b474635ccdf111e2269dbf33e629ce0b Cr-Commit-Position: refs/heads/master@{#38445} ========== to ========== [test] Split TurboFan mjsunit expectations for variants. R=machenbach@chromium.org Committed: https://crrev.com/5eed70c6b474635ccdf111e2269dbf33e629ce0b Committed: https://crrev.com/025ddb21efec84fdac3d7e28a301e620571cd933 Cr-Original-Commit-Position: refs/heads/master@{#38445} Cr-Commit-Position: refs/heads/master@{#38452} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/025ddb21efec84fdac3d7e28a301e620571cd933 Cr-Commit-Position: refs/heads/master@{#38452}
Message was sent while issue was closed.
lgtm |
