Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Issue 222583003: Fix ios build in chromium when targeting multiple architectures (Closed)

Created:
6 years, 8 months ago by djsollen
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix ios build in chromium when targeting multiple architectures R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=14048

Patch Set 1 #

Patch Set 2 : remove simulator condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/core/SkPreConfig.h View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
djsollen
6 years, 8 months ago (2014-04-03 17:38:48 UTC) #1
robertphillips
lgtm
6 years, 8 months ago (2014-04-03 17:48:32 UTC) #2
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 8 months ago (2014-04-03 17:49:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/222583003/20001
6 years, 8 months ago (2014-04-03 17:49:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 17:49:15 UTC) #5
commit-bot: I haz the power
Presubmit check for 222583003-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 8 months ago (2014-04-03 17:49:16 UTC) #6
djsollen
The CQ bit was unchecked by djsollen@google.com
6 years, 8 months ago (2014-04-03 17:49:27 UTC) #7
djsollen
6 years, 8 months ago (2014-04-03 17:50:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r14048.

Powered by Google App Engine
This is Rietveld 408576698