Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2225813004: Added back a dropped event-type check. (Closed)

Created:
4 years, 4 months ago by mustaq
Modified:
4 years, 4 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added back a dropped event-type check. BUG=635571 Committed: https://crrev.com/d6f91db2f44e1d429f625b61e8f41016cac0c3a1 Cr-Commit-Position: refs/heads/master@{#411086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
mustaq
ptal
4 years, 4 months ago (2016-08-09 17:56:52 UTC) #2
bokan
lgtm
4 years, 4 months ago (2016-08-09 18:59:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225813004/1
4 years, 4 months ago (2016-08-09 19:03:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/270245)
4 years, 4 months ago (2016-08-09 22:45:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225813004/1
4 years, 4 months ago (2016-08-10 14:50:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 18:27:51 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 18:29:42 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d6f91db2f44e1d429f625b61e8f41016cac0c3a1
Cr-Commit-Position: refs/heads/master@{#411086}

Powered by Google App Engine
This is Rietveld 408576698