Issue 22258005: Upstreaming DropShadowImageFilter into skia, from Blink

Issue 22258005: Upstreaming DropShadowImageFilter into skia, from Blink (Closed)

Created:
7 years, 4 months ago by Justin Novosad

Modified:
7 years, 4 months ago

Reviewers:
Stephen White, senorblanco

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Upstreaming DropShadowImageFilter into skia, from Blink GM imagefiltersbase will need rebaselining after this change R=senorblanco@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=10583 Committed: https://code.google.com/p/skia/source/detail?r=10626

Patch Set 4 : Upstreaming DropShadowImageFilter into skia, from Blink #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
M	gm/imagefiltersbase.cpp	View	1 2 3	3 chunks	+3 lines, -1 line	0 comments	Download
M	gyp/effects.gypi	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
A +	include/effects/SkDropShadowImageFilter.h	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/effects/SkDropShadowImageFilter.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ports/SkGlobalInitialization_default.cpp	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

https://codereview.chromium.org/22258005/diff/1/src/effects/SkDropShadowImageFilter.cpp File src/effects/SkDropShadowImageFilter.cpp (right): https://codereview.chromium.org/22258005/diff/1/src/effects/SkDropShadowImageFilter.cpp#newcode36 src/effects/SkDropShadowImageFilter.cpp:36: this->INHERITED::flatten(buffer); FYI: This line was missing in the Blink ...

7 years, 4 months ago (2013-08-06 19:27:24 UTC) #1

Stephen White

https://codereview.chromium.org/22258005/diff/1/include/effects/SkDropShadowImageFilter.h File include/effects/SkDropShadowImageFilter.h (right): https://codereview.chromium.org/22258005/diff/1/include/effects/SkDropShadowImageFilter.h#newcode14 include/effects/SkDropShadowImageFilter.h:14: SkDropShadowImageFilter(SkScalar dx, SkScalar dy, SkScalar sigma, SkColor, SkImageFilter* input ...

7 years, 4 months ago (2013-08-06 19:33:37 UTC) #2

Stephen White

https://codereview.chromium.org/22258005/diff/12001/include/effects/SkDropShadowImageFilter.h File include/effects/SkDropShadowImageFilter.h (right): https://codereview.chromium.org/22258005/diff/12001/include/effects/SkDropShadowImageFilter.h#newcode12 include/effects/SkDropShadowImageFilter.h:12: class SkDropShadowImageFilter : public SkImageFilter { BTW, you'll probably ...

7 years, 4 months ago (2013-08-06 19:51:38 UTC) #5

Justin Novosad

Committed patchset #3 manually as r10583 (presubmit successful).

7 years, 4 months ago (2013-08-06 20:01:44 UTC) #6

Justin Novosad

On 2013/08/06 20:01:44, junov wrote: > Committed patchset #3 manually as r10583 (presubmit successful). Re-opened ...

7 years, 4 months ago (2013-08-07 19:37:55 UTC) #7

Justin Novosad

Upstreaming DropShadowImageFilter into skia, from Blink GM imagefiltersbase will need rebaselining after this change R=senorblanco@chromium.org ...

7 years, 4 months ago (2013-08-07 19:40:39 UTC) #8

Justin Novosad

7 years, 4 months ago (2013-08-07 20:01:00 UTC) #9

Message was sent while issue was closed.

Committed patchset #4 manually as r10626 (presubmit successful).

Expand Messages | Collapse Messages