Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2225753003: Revert of Add per-section clearing and dismissed suggestions to snippets-internals (Closed)

Created:
4 years, 4 months ago by anthonyvd
Modified:
4 years, 4 months ago
CC:
chromium-reviews, arv+watch_chromium.org, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add per-section clearing and dismissed suggestions to snippets-internals (patchset #3 id:40001 of https://codereview.chromium.org/2222853004/ ) Reason for revert: Reverting this CL because it breaks the following bot: https://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/70928 Original issue's description: > Add per-section clearing and dismissed suggestions to snippets-internals > > Add new ClearCachedSuggestionsForDebugging, > GetDismissedSuggestionsForDebugging and > ClearDismissedSuggestionsForDebugging methods to the > ContentSuggestionsProvider. Implement these methods in all existing > providers. Adjust the unit tests. > > Call those methods from snippets-internals, build new internals UI for > viewing dismissed suggestions and clearing suggestions per category. > Remove now unused NTPSnippetsService-related things. > > BUG=619560 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b > Cr-Commit-Position: refs/heads/master@{#410360} TBR=treib@chromium.org,bauerb@chromium.org,pke@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -406 lines) Patch
M chrome/browser/resources/snippets_internals.html View 6 chunks +99 lines, -58 lines 0 comments Download
M chrome/browser/resources/snippets_internals.js View 7 chunks +38 lines, -29 lines 0 comments Download
M chrome/browser/ui/webui/snippets_internals_message_handler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/snippets_internals_message_handler.cc View 8 chunks +121 lines, -63 lines 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h View 1 chunk +2 lines, -4 lines 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc View 2 chunks +3 lines, -16 lines 0 comments Download
M components/ntp_snippets/content_suggestions_provider.h View 1 chunk +7 lines, -15 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.h View 1 chunk +8 lines, -22 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.cc View 1 chunk +7 lines, -30 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 2 chunks +13 lines, -9 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 5 chunks +42 lines, -67 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 24 chunks +63 lines, -70 lines 0 comments Download
M components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h View 1 chunk +2 lines, -4 lines 0 comments Download
M components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc View 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
anthonyvd
Created Revert of Add per-section clearing and dismissed suggestions to snippets-internals
4 years, 4 months ago (2016-08-08 15:48:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225753003/1
4 years, 4 months ago (2016-08-08 15:49:04 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 15:50:14 UTC) #5
Failed to apply the patch.

Powered by Google App Engine
This is Rietveld 408576698