third_party/WebKit/Source/core/animation/CompositorAnimations.cpp - Issue 2225743002: Use same layout logic in animations for deciding whether an element can transform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

Issue 2225743002: Use same layout logic in animations for deciding whether an element can transform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/virtual/threaded/animations/img-element-transform.html ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

diff --git a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

index 776a6d452776a33388b92315943d5b101573c061..2489ac4d85d5437500c4a61f13e15b33efcf6ba0 100644

--- a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

+++ b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

@@ -241,7 +241,7 @@ bool CompositorAnimations::isCandidateForAnimationOnCompositor(const Timing& tim

return false;

if (isTransformRelatedCSSProperty(property)) {

- if (targetElement.layoutObject() && targetElement.layoutObject()->isInline() && !targetElement.layoutObject()->isInlineBlockOrInlineTable()) {

+ if (targetElement.layoutObject() && !targetElement.layoutObject()->canTransformOnCompositor()) {

return false;

}

transformPropertyCount++;