Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2225723002: V4L2VideoEncodeAccelerator: increase the number of input buffers to 2. (Closed)

Created:
4 years, 4 months ago by wuchengli
Modified:
4 years, 4 months ago
Reviewers:
Owen Lin, Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

V4L2VideoEncodeAccelerator: increase the number of input buffers to 2. The default number of input buffer was only one. When encoding continuously, encoder would starve from input buffers. Change the default number of input buffers to two to improve performance. From testing, three input buffers do not improve the performance further. BUG=chromium:627020 TEST=Run VEA test on CrOS oak, veyron-minnie, nyan-big, and peach-pit. Committed: https://crrev.com/bcdbb72470c705f4363a4cbe87eb8f9686b55088 Cr-Commit-Position: refs/heads/master@{#410306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/gpu/v4l2_video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
wuchengli
PTAL.
4 years, 4 months ago (2016-08-08 03:59:34 UTC) #2
Pawel Osciak
lgtm
4 years, 4 months ago (2016-08-08 04:55:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225723002/1
4 years, 4 months ago (2016-08-08 04:57:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 06:00:26 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 06:02:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcdbb72470c705f4363a4cbe87eb8f9686b55088
Cr-Commit-Position: refs/heads/master@{#410306}

Powered by Google App Engine
This is Rietveld 408576698