Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2225683004: [modules] Don't force context allocation of variables declared in module scope. (Closed)

Created:
4 years, 4 months ago by neis
Modified:
4 years, 4 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Don't force context allocation of variables declared in module scope. There's no need to do so. Also simplify NeedsContext(), which doesn't need to check for with-scopes. R=adamk@chromium.org BUG= Committed: https://crrev.com/33f3262f557c36fdc6c2eca41660774b419c8fbc Cr-Commit-Position: refs/heads/master@{#38451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/ast/scopes.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ast/scopes.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 4 months ago (2016-08-08 13:42:57 UTC) #1
adamk
lgtm
4 years, 4 months ago (2016-08-08 15:35:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225683004/1
4 years, 4 months ago (2016-08-08 15:42:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 16:16:35 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 16:19:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33f3262f557c36fdc6c2eca41660774b419c8fbc
Cr-Commit-Position: refs/heads/master@{#38451}

Powered by Google App Engine
This is Rietveld 408576698