Support exporting Mojo bindings for the component build.

Support exporting Mojo bindings for the component build.

The problem is when using typemaps, the source_set for the generated bindings may include headers from components they're linking with. The export macros for those components need to match other files in the component, or else the linker warnings in the bug below are encountered.

A couple of other solutions were attempted first, since they seemed simpler, but they didn't work out:
-make the typemapped types be separate components: https://codereview.chromium.org/2194973002/. This wouldn't work for the weborigin example as future plans render making it a leaf-node not possible.
-make the other components compile the generated bindings as part of their source: https://codereview.chromium.org/2209883002/. This solution requires the mojom target to be in the same build file as the component, which doesn't work when the issue is hit with both variants.

BUG=632082
Committed: https://crrev.com/b97b473d63918a01716254be849d248a7d3eefa8
Cr-Commit-Position: refs/heads/master@{#410451}

[jam, 2016-08-08 00:13:44]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 00:13:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 00:16:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 00:16:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2016-08-08 03:02:04]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 03:02:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-08-08 06:13:19]

Patchset #1 (id:1) has been deleted

[jam, 2016-08-08 06:18:15]

Description was changed from

==========
Export Mojo bindings

BUG=
==========

to

==========
Support exporting Mojo bindings for the component build.

The problem is when using typemaps, the source_set for the generated bindings
may include headers from components they're linking with. The export macros for
those components need to match other files in the component, or else the linker
warnings in the bug below are encountered.

A couple of other solutions were attempted first, since they seemed simpler, but
they didn't work out:
-make the typemapped types be separate components:
https://codereview.chromium.org/2194973002/. This wouldn't work for the
weborigin example as future plans render making it a leaf-node not possible.
-make the other components compile the generated bindings as part of their
source: https://codereview.chromium.org/2209883002/. This solution requires the
mojom target to be in the same build file as the component, which doesn't work
when the issue is hit with both variants.

BUG=632082
==========

[jam, 2016-08-08 06:18:15]

jam@chromium.org changed reviewers:
+ yzshen@chromium.org

[jam, 2016-08-08 06:19:41]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 06:19:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-08-08 06:47:51]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 06:48:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 07:17:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 07:17:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2016-08-08 15:22:17]

Patchset #2 (id:40001) has been deleted

[jam, 2016-08-08 15:23:38]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 15:23:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-08-08 16:50:43]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-08-08 16:54:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 16:54:48]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[yzshen1, 2016-08-08 17:07:32]

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
File
mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl
(right):

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl:10:
class {{export_attribute}} {{interface.export}} {{interface.name}} {
what is {{interface.export}}?

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
File
mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl
(right):

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl:6:
struct {{export_attribute}} StructTraits<{{mojom_type}}, {{mojom_type}}Ptr> {
Please also add export_attribute to
- enum_serialization_declaration
- struct_data_view_declaration
- union_serialization_declaration

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/mojom.gni (right):

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/mojom.gni:266: if
(defined(invoker.export_class_attribute) &&
It seems simpler to merge these new if's with line 257-260:

if (defined(bindings_configuration.for_blink) &&
    bindings_configuration.for_blink) {
  args += [ "--for_blink" ]
  if (defined(invoker.export_class_attribute_blink)) {
    args += [
      "--export_attribute",
      invoker.export_class_attribute_blink,
      "--export_header",
      invoker.export_header_blink,
    ]
  }
} else {
  # add the chromium export_attributes and export header, if defined.
  ...
}

[jam, 2016-08-08 17:36:08]

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
File
mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl
(right):

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl:10:
class {{export_attribute}} {{interface.export}} {{interface.name}} {
On 2016/08/08 17:07:32, yzshen1 wrote:
> what is {{interface.export}}?

oops, that's from a previous iteration. removed.

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
File
mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl
(right):

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl:6:
struct {{export_attribute}} StructTraits<{{mojom_type}}, {{mojom_type}}Ptr> {
On 2016/08/08 17:07:32, yzshen1 wrote:
> Please also add export_attribute to
> - enum_serialization_declaration

Done

> - struct_data_view_declaration

I had them previously but I got win_clang errors since it said they were
unnecessary. I can add them again to show you the error since I deleted the
previous patchset.

> - union_serialization_declaration

Done

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
File mojo/public/tools/bindings/mojom.gni (right):

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/mojom.gni:266: if
(defined(invoker.export_class_attribute) &&
On 2016/08/08 17:07:32, yzshen1 wrote:
> It seems simpler to merge these new if's with line 257-260:
> 
> if (defined(bindings_configuration.for_blink) &&
>     bindings_configuration.for_blink) {
>   args += [ "--for_blink" ]
>   if (defined(invoker.export_class_attribute_blink)) {
>     args += [
>       "--export_attribute",
>       invoker.export_class_attribute_blink,
>       "--export_header",
>       invoker.export_header_blink,
>     ]
>   }
> } else {
>   # add the chromium export_attributes and export header, if defined.
>   ...
> }
> 

Done.

[jam, 2016-08-08 17:36:18]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 17:36:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-08-08 17:42:16]

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
File
mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl
(right):

https://codereview.chromium.org/2225673002/diff/80001/mojo/public/tools/bindi...
mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl:6:
struct {{export_attribute}} StructTraits<{{mojom_type}}, {{mojom_type}}Ptr> {
> > - struct_data_view_declaration
> 
> I had them previously but I got win_clang errors since it said they were
> unnecessary. I can add them again to show you the error since I deleted the
> previous patchset.

Thanks! Is it because it is a non-template class and inlined entirely?
I would be happy to learn about the cause.

[jam, 2016-08-08 17:52:58]

Patchset #4 (id:120001) has been deleted

[jam, 2016-08-08 17:53:00]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 17:53:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-08-08 18:19:08]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 18:19:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-08-08 19:26:28]

lgtm

[jam, 2016-08-08 19:40:36]

jam@chromium.org changed reviewers:
+ esprehn@chromium.org

[jam, 2016-08-08 19:41:49]

+esprehn for webkit/

This is instead of https://codereview.chromium.org/2209883002/, which doesn't
work anymore now that we have typemaps from the blink interfaces in content
(which is a valid usecase of course).

[esprehn, 2016-08-08 20:09:02]

lgtm

[esprehn, 2016-08-08 20:09:19]

btw it's nice if you wrap your change description at 80 or 100 columns.

[jam, 2016-08-08 20:20:55]

The CQ bit was unchecked by jam@chromium.org

[jam, 2016-08-08 20:21:22]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-08-08 20:21:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-08-08 20:48:23]

Description was changed from

==========
Support exporting Mojo bindings for the component build.

The problem is when using typemaps, the source_set for the generated bindings
may include headers from components they're linking with. The export macros for
those components need to match other files in the component, or else the linker
warnings in the bug below are encountered.

A couple of other solutions were attempted first, since they seemed simpler, but
they didn't work out:
-make the typemapped types be separate components:
https://codereview.chromium.org/2194973002/. This wouldn't work for the
weborigin example as future plans render making it a leaf-node not possible.
-make the other components compile the generated bindings as part of their
source: https://codereview.chromium.org/2209883002/. This solution requires the
mojom target to be in the same build file as the component, which doesn't work
when the issue is hit with both variants.

BUG=632082
==========

to

==========
Support exporting Mojo bindings for the component build.

The problem is when using typemaps, the source_set for the generated bindings
may include headers from components they're linking with. The export macros
for those components need to match other files in the component, or else the
linker warnings in the bug below are encountered.

A couple of other solutions were attempted first, since they seemed simpler,
but they didn't work out:
- make the typemapped types be separate components:
  https://codereview.chromium.org/2194973002/. This wouldn't work for the
  weborigin example as future plans render making it a leaf-node not possible.
- make the other components compile the generated bindings as part of their
  source: https://codereview.chromium.org/2209883002/. This solution requires
  the mojom target to be in the same build file as the component, which
  doesn't work when the issue is hit with both variants.

BUG=632082
==========

[commit-bot: I haz the power, 2016-08-08 20:48:53]

Committed patchset #5 (id:160001)

[commit-bot: I haz the power, 2016-08-08 20:50:54]

Description was changed from

==========
Support exporting Mojo bindings for the component build.

The problem is when using typemaps, the source_set for the generated bindings
may include headers from components they're linking with. The export macros
for those components need to match other files in the component, or else the
linker warnings in the bug below are encountered.

A couple of other solutions were attempted first, since they seemed simpler,
but they didn't work out:
- make the typemapped types be separate components:
  https://codereview.chromium.org/2194973002/. This wouldn't work for the
  weborigin example as future plans render making it a leaf-node not possible.
- make the other components compile the generated bindings as part of their
  source: https://codereview.chromium.org/2209883002/. This solution requires
  the mojom target to be in the same build file as the component, which
  doesn't work when the issue is hit with both variants.

BUG=632082
==========

to

==========
Support exporting Mojo bindings for the component build.

The problem is when using typemaps, the source_set for the generated bindings
may include headers from components they're linking with. The export macros for
those components need to match other files in the component, or else the linker
warnings in the bug below are encountered.

A couple of other solutions were attempted first, since they seemed simpler, but
they didn't work out:
-make the typemapped types be separate components:
https://codereview.chromium.org/2194973002/. This wouldn't work for the
weborigin example as future plans render making it a leaf-node not possible.
-make the other components compile the generated bindings as part of their
source: https://codereview.chromium.org/2209883002/. This solution requires the
mojom target to be in the same build file as the component, which doesn't work
when the issue is hit with both variants.

BUG=632082

Committed: https://crrev.com/b97b473d63918a01716254be849d248a7d3eefa8
Cr-Commit-Position: refs/heads/master@{#410451}
==========

[commit-bot: I haz the power, 2016-08-08 20:50:56]

Patchset 5 (id:??) landed as
https://crrev.com/b97b473d63918a01716254be849d248a7d3eefa8
Cr-Commit-Position: refs/heads/master@{#410451}