Issue 22256004: Compute available disk space in Files.app by statvfs.f_bavail, not f_free

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22256004: Compute available disk space in Files.app by statvfs.f_bavail, not f_free (Closed)

Created:
7 years, 4 months ago by kinaba

Modified:
7 years, 4 months ago

Reviewers:
hidehiko

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Compute available disk space in Files.app by statvfs.f_bavail, not .f_bfree. f_bavail is more appropriate because it tells the amount of disk space that is available to a non-privileged user. (Writing to Downloads/ indeed stops working if f_bavail=0.) BUG=268705 TEST=Checked the gear menu value matches with what chrome:drive-internals shows. R=hidehiko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215815

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/22256004/1

7 years, 4 months ago (2013-08-06 04:04:09 UTC) #3

kinaba

7 years, 4 months ago (2013-08-06 06:11:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r215815 (presubmit successful).

Expand Messages | Collapse Messages