Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2225583002: Support devFS writes via HTTP PUT (Closed)

Created:
4 years, 4 months ago by Cutch
Modified:
4 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support devFS writes via HTTP PUT - [x] Allow DevFS writes over HTTP PUT with a gzip compressed payload. - [x] Add service test for http put writes. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/a67b9c82ee7cc74ca9623843887412768d1eed28

Patch Set 1 #

Patch Set 2 : Support devFS writes via HTTP PUT #

Patch Set 3 : . #

Patch Set 4 : .. #

Total comments: 4

Patch Set 5 : rmacnak review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -5 lines) Patch
M runtime/bin/vmservice/server.dart View 1 2 3 4 1 chunk +33 lines, -1 line 0 comments Download
M runtime/bin/vmservice/vmservice_io.dart View 1 2 chunks +10 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/dev_fs_http_put_test.dart View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
M sdk/lib/vmservice/devfs.dart View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
M sdk/lib/vmservice/message.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/vmservice/vmservice.dart View 1 5 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Cutch
4 years, 4 months ago (2016-08-08 15:02:35 UTC) #3
rmacnak
https://codereview.chromium.org/2225583002/diff/60001/runtime/bin/vmservice/server.dart File runtime/bin/vmservice/server.dart (right): https://codereview.chromium.org/2225583002/diff/60001/runtime/bin/vmservice/server.dart#newcode169 runtime/bin/vmservice/server.dart:169: Object fsNameList; var or List: fsNameList[0] below is a ...
4 years, 4 months ago (2016-08-08 16:33:42 UTC) #5
Cutch
https://codereview.chromium.org/2225583002/diff/60001/runtime/bin/vmservice/server.dart File runtime/bin/vmservice/server.dart (right): https://codereview.chromium.org/2225583002/diff/60001/runtime/bin/vmservice/server.dart#newcode169 runtime/bin/vmservice/server.dart:169: Object fsNameList; On 2016/08/08 16:33:42, rmacnak wrote: > var ...
4 years, 4 months ago (2016-08-08 17:22:06 UTC) #6
rmacnak
lgtm
4 years, 4 months ago (2016-08-08 17:23:06 UTC) #7
Cutch
4 years, 4 months ago (2016-08-08 17:35:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
a67b9c82ee7cc74ca9623843887412768d1eed28 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698