Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2225563002: Reland "Raster display item lists via a visual rect RTree." (Closed)

Created:
4 years, 4 months ago by wkorman
Modified:
4 years, 4 months ago
Reviewers:
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbauman+watch_chromium.org, jbroman, Justin Novosad, kalyank, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, sievers+watch_chromium.org, tfarina, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Raster display item lists via a visual rect RTree." Rather than caching and playing back an entire SkPicture when rastering a display item list for a particular playback rect, instead retain display items and query them via an RTree of their visual rects to find and raster only what's needed. Display item lists no longer support the notion of a bounding "layer rect" with mutable origin. DisplayItemListSettings proto is obsolete after this change as it's comprised solely of one field to allow switching whether to use the aforementioned now-deleted cached SkPicture code path. It will be deleted in a subsequent patch. Last reverted change: http://crrev.com/2217263003 BUG=529938 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=chrishtr,vmpstr Committed: https://crrev.com/971a9c9725e293bd89b7cb1475acdc502065e6b3 Cr-Commit-Position: refs/heads/master@{#411560}

Patch Set 1 #

Patch Set 2 : Sync to head and fix expectations. #

Patch Set 3 : Restore layer_rect to JSON to avoid breaking tracing. #

Patch Set 4 : Sync to head. #

Patch Set 5 : Sync to head -- merge 2230513005 #

Patch Set 6 : Sync to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -412 lines) Patch
M cc/blink/web_content_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/blink/web_display_item_list_impl.cc View 1 2 3 4 5 6 chunks +30 lines, -92 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark.h View 2 chunks +1 line, -1 line 0 comments Download
M cc/debug/rasterize_and_record_benchmark.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/empty_content_layer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_image_layer.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/playback/discardable_image_map_unittest.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M cc/playback/display_item_list.h View 1 2 3 4 5 7 chunks +18 lines, -30 lines 0 comments Download
M cc/playback/display_item_list.cc View 1 2 3 4 10 chunks +74 lines, -141 lines 0 comments Download
M cc/playback/display_item_list_unittest.cc View 1 2 3 4 5 17 chunks +60 lines, -83 lines 0 comments Download
M cc/playback/recording_source.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/proto/display_item.proto View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_content_layer_client.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/skia_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/solid_color_content_layer_client.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_tiles.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +66 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 2 3 4 1 chunk +13 lines, -5 lines 0 comments Download
M ui/compositor/canvas_painter.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/compositor/layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view_unittest.cc View 27 chunks +38 lines, -38 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225563002/80001
4 years, 4 months ago (2016-08-11 18:49:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/builds/716)
4 years, 4 months ago (2016-08-11 19:55:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225563002/100001
4 years, 4 months ago (2016-08-12 04:12:37 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-08-12 05:53:44 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 05:55:27 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/971a9c9725e293bd89b7cb1475acdc502065e6b3
Cr-Commit-Position: refs/heads/master@{#411560}

Powered by Google App Engine
This is Rietveld 408576698