Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2225543002: chromeos: Add note-taking-app utility functions. (Closed)

Created:
4 years, 4 months ago by Daniel Erat
Modified:
4 years, 4 months ago
Reviewers:
jdufault
CC:
chromium-reviews, kalyank, sadrul, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Add note-taking-app utility functions. Add utility functions that can be used to check whether a note-taking app is available and to launch it. BUG=605805, 606398, 616112 Committed: https://crrev.com/d7ce54d935656d46f85fcfe201bf84239fa5ce50 Cr-Commit-Position: refs/heads/master@{#410450}

Patch Set 1 #

Patch Set 2 : add DCHECK #

Total comments: 4

Patch Set 3 : update TODOs #

Patch Set 4 : reupload #

Total comments: 4

Patch Set 5 : update TODO for review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -1 line) Patch
M ash/common/system/chromeos/palette/palette_utils.cc View 3 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/chromeos/note_taking_app_utils.h View 3 1 chunk +27 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/note_taking_app_utils.cc View 1 2 3 4 1 chunk +87 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 3 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 3 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Daniel Erat
4 years, 4 months ago (2016-08-05 22:37:13 UTC) #3
jdufault
https://codereview.chromium.org/2225543002/diff/20001/chrome/browser/chromeos/note_taking_app_utils.cc File chrome/browser/chromeos/note_taking_app_utils.cc (right): https://codereview.chromium.org/2225543002/diff/20001/chrome/browser/chromeos/note_taking_app_utils.cc#newcode75 chrome/browser/chromeos/note_taking_app_utils.cc:75: // TODO: Launch with an "action" launch source and ...
4 years, 4 months ago (2016-08-05 22:59:38 UTC) #5
Daniel Erat
https://codereview.chromium.org/2225543002/diff/20001/chrome/browser/chromeos/note_taking_app_utils.cc File chrome/browser/chromeos/note_taking_app_utils.cc (right): https://codereview.chromium.org/2225543002/diff/20001/chrome/browser/chromeos/note_taking_app_utils.cc#newcode75 chrome/browser/chromeos/note_taking_app_utils.cc:75: // TODO: Launch with an "action" launch source and ...
4 years, 4 months ago (2016-08-05 23:19:23 UTC) #6
Daniel Erat
let me know if this looks okay. we'll definitely need to change it later to ...
4 years, 4 months ago (2016-08-06 00:22:23 UTC) #9
Daniel Erat
uh, where'd my changes go? :-/ let me try to figure out what went wrong ...
4 years, 4 months ago (2016-08-08 18:47:12 UTC) #10
Daniel Erat
okay, mind taking a look at this?
4 years, 4 months ago (2016-08-08 19:25:39 UTC) #11
jdufault
lgtm https://codereview.chromium.org/2225543002/diff/60001/chrome/browser/chromeos/note_taking_app_utils.cc File chrome/browser/chromeos/note_taking_app_utils.cc (right): https://codereview.chromium.org/2225543002/diff/60001/chrome/browser/chromeos/note_taking_app_utils.cc#newcode39 chrome/browser/chromeos/note_taking_app_utils.cc:39: const std::string switch_value = Pull into a helper ...
4 years, 4 months ago (2016-08-08 19:44:24 UTC) #14
Daniel Erat
https://codereview.chromium.org/2225543002/diff/60001/chrome/browser/chromeos/note_taking_app_utils.cc File chrome/browser/chromeos/note_taking_app_utils.cc (right): https://codereview.chromium.org/2225543002/diff/60001/chrome/browser/chromeos/note_taking_app_utils.cc#newcode39 chrome/browser/chromeos/note_taking_app_utils.cc:39: const std::string switch_value = On 2016/08/08 19:44:23, jdufault wrote: ...
4 years, 4 months ago (2016-08-08 20:04:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225543002/80001
4 years, 4 months ago (2016-08-08 20:09:43 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-08 20:44:59 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 20:47:18 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d7ce54d935656d46f85fcfe201bf84239fa5ce50
Cr-Commit-Position: refs/heads/master@{#410450}

Powered by Google App Engine
This is Rietveld 408576698