Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 222553007: [webcrypto] Expose crypto.subtle to web workers. (Closed)

Created:
6 years, 8 months ago by eroman
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

[webcrypto] Expose crypto.subtle to web workers. This corresponds with the spec update: https://dvcs.w3.org/hg/webcrypto-api/rev/9f1f378595fc BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170740

Patch Set 1 : #

Patch Set 2 : check if changes... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -204 lines) Patch
M LayoutTests/crypto/hmac-sign-verify.html View 2 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/crypto/resources/common.js View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/crypto/resources/subtle-crypto-concurrent.js View 1 chunk +170 lines, -0 lines 0 comments Download
A LayoutTests/crypto/worker-subtle-crypto-concurrent.html View 1 chunk +73 lines, -0 lines 0 comments Download
A LayoutTests/crypto/worker-subtle-crypto-concurrent-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/bindings/bindings.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8CryptoCustom.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
D Source/bindings/v8/custom/V8WorkerCryptoCustom.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
M Source/modules/crypto/Crypto.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/Crypto.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/modules/crypto/WorkerCrypto.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/modules/crypto/WorkerCrypto.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D Source/modules/crypto/WorkerCrypto.idl View 1 chunk +0 lines, -36 lines 0 comments Download
M Source/modules/crypto/WorkerGlobalScopeCrypto.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/crypto/WorkerGlobalScopeCrypto.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/crypto/WorkerGlobalScopeCrypto.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/modules.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eroman
6 years, 8 months ago (2014-04-03 00:40:41 UTC) #1
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-03 05:00:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/222553007/40001
6 years, 8 months ago (2014-04-03 05:01:00 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 05:02:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-03 05:02:53 UTC) #5
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 8 months ago (2014-04-03 06:23:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/222553007/40001
6 years, 8 months ago (2014-04-03 06:23:42 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 06:24:10 UTC) #8
Message was sent while issue was closed. 
Change committed as 170740

Powered by Google App Engine
This is Rietveld 408576698