Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: ui/app_list/app_list_switches.cc

Issue 222553003: Disable AppList sync by default on non Chrome OS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/app_list_switches.h ('k') | ui/app_list/views/apps_grid_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/app_list_switches.cc
diff --git a/ui/app_list/app_list_switches.cc b/ui/app_list/app_list_switches.cc
index c1e05026b1f152e69fcea4f547bec8359b0e8287..31842f2563ba4d6eda73de4754602f7edbdaf9dd 100644
--- a/ui/app_list/app_list_switches.cc
+++ b/ui/app_list/app_list_switches.cc
@@ -9,8 +9,8 @@
namespace app_list {
namespace switches {
-// If set, folder will be disabled in app list UI.
-const char kDisableFolderUI[] = "disable-app-list-folder-ui";
+// Disables syncing of the app list independent of extensions.
+const char kDisableSyncAppList[] = "disable-sync-app-list";
// If set, the voice search is disabled in app list UI.
const char kDisableVoiceSearch[] = "disable-app-list-voice-search";
@@ -29,13 +29,24 @@ const char kEnableExperimentalAppListPosition[] =
// when the hotword is recognized.
const char kEnableHotwordAlwaysOn[] = "enable-app-list-hotword-always-on";
-// Folder UI is enabled by default.
-bool IsFolderUIEnabled() {
-#if !defined(OS_MACOSX)
- return !CommandLine::ForCurrentProcess()->HasSwitch(kDisableFolderUI);
+// Enables syncing of the app list independent of extensions.
+const char kEnableSyncAppList[] = "enable-sync-app-list";
+
+bool IsAppListSyncEnabled() {
+#if defined(OS_CHROMEOS)
+ return !CommandLine::ForCurrentProcess()->HasSwitch(kDisableSyncAppList);
#else
- return false;
+ return CommandLine::ForCurrentProcess()->HasSwitch(kEnableSyncAppList);
+#endif
+}
+
+bool IsFolderUIEnabled() {
+#if defined(OS_MACOSX)
+ return false; // Folder UI not implemented for OSX
#endif
+ // Folder UI is available only when AppList sync is enabled, and should
+ // not be disabled separately.
+ return IsAppListSyncEnabled();
}
bool IsVoiceSearchEnabled() {
« no previous file with comments | « ui/app_list/app_list_switches.h ('k') | ui/app_list/views/apps_grid_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698