Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 222553003: Disable AppList sync by default on non Chrome OS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Elim --disable-app-list-folder-ui Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 switches::kTouchScrollingMode, 394 switches::kTouchScrollingMode,
395 switches::kTouchScrollingModeTouchcancel }, 395 switches::kTouchScrollingModeTouchcancel },
396 { IDS_FLAGS_TOUCH_SCROLLING_MODE_ABSORB_TOUCHMOVE, 396 { IDS_FLAGS_TOUCH_SCROLLING_MODE_ABSORB_TOUCHMOVE,
397 switches::kTouchScrollingMode, 397 switches::kTouchScrollingMode,
398 switches::kTouchScrollingModeAbsorbTouchmove }, 398 switches::kTouchScrollingModeAbsorbTouchmove },
399 { IDS_FLAGS_TOUCH_SCROLLING_MODE_SYNC_TOUCHMOVE, 399 { IDS_FLAGS_TOUCH_SCROLLING_MODE_SYNC_TOUCHMOVE,
400 switches::kTouchScrollingMode, 400 switches::kTouchScrollingMode,
401 switches::kTouchScrollingModeSyncTouchmove }, 401 switches::kTouchScrollingModeSyncTouchmove },
402 }; 402 };
403 403
404 #if defined(ENABLE_APP_LIST)
405 const Experiment::Choice kEnableSyncAppListChoices[] = {
406 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
407 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
408 app_list::switches::kEnableSyncAppList, "" },
409 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
410 app_list::switches::kDisableSyncAppList, "" },
411 };
412 #endif
413
404 // RECORDING USER METRICS FOR FLAGS: 414 // RECORDING USER METRICS FOR FLAGS:
405 // ----------------------------------------------------------------------------- 415 // -----------------------------------------------------------------------------
406 // The first line of the experiment is the internal name. If you'd like to 416 // The first line of the experiment is the internal name. If you'd like to
407 // gather statistics about the usage of your flag, you should append a marker 417 // gather statistics about the usage of your flag, you should append a marker
408 // comment to the end of the feature name, like so: 418 // comment to the end of the feature name, like so:
409 // "my-special-feature", // FLAGS:RECORD_UMA 419 // "my-special-feature", // FLAGS:RECORD_UMA
410 // 420 //
411 // After doing that, run 421 // After doing that, run
412 // tools/metrics/actions/extract_actions.py 422 // tools/metrics/actions/extract_actions.py
413 // to add the metric to actions.xml (which will enable UMA to record your 423 // to add the metric to actions.xml (which will enable UMA to record your
(...skipping 790 matching lines...) Expand 10 before | Expand all | Expand 10 after
1204 { 1214 {
1205 "enable-sync-synced-notifications", 1215 "enable-sync-synced-notifications",
1206 IDS_FLAGS_ENABLE_SYNCED_NOTIFICATIONS_NAME, 1216 IDS_FLAGS_ENABLE_SYNCED_NOTIFICATIONS_NAME,
1207 IDS_FLAGS_ENABLE_SYNCED_NOTIFICATIONS_DESCRIPTION, 1217 IDS_FLAGS_ENABLE_SYNCED_NOTIFICATIONS_DESCRIPTION,
1208 kOsDesktop, 1218 kOsDesktop,
1209 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableSyncSyncedNotifications, 1219 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableSyncSyncedNotifications,
1210 switches::kDisableSyncSyncedNotifications) 1220 switches::kDisableSyncSyncedNotifications)
1211 }, 1221 },
1212 #if defined(ENABLE_APP_LIST) 1222 #if defined(ENABLE_APP_LIST)
1213 { 1223 {
1214 "disable-sync-app-list", 1224 "enable-sync-app-list",
1215 IDS_FLAGS_DISABLE_SYNC_APP_LIST_NAME, 1225 IDS_FLAGS_ENABLE_SYNC_APP_LIST_NAME,
1216 IDS_FLAGS_DISABLE_SYNC_APP_LIST_DESCRIPTION, 1226 IDS_FLAGS_ENABLE_SYNC_APP_LIST_DESCRIPTION,
1217 kOsDesktop, 1227 kOsDesktop,
1218 SINGLE_VALUE_TYPE(switches::kDisableSyncAppList) 1228 MULTI_VALUE_TYPE(kEnableSyncAppListChoices)
1219 }, 1229 },
1220 #endif 1230 #endif
1221 { 1231 {
1222 "enable-usermedia-screen-capture", 1232 "enable-usermedia-screen-capture",
1223 IDS_FLAGS_ENABLE_SCREEN_CAPTURE_NAME, 1233 IDS_FLAGS_ENABLE_SCREEN_CAPTURE_NAME,
1224 IDS_FLAGS_ENABLE_SCREEN_CAPTURE_DESCRIPTION, 1234 IDS_FLAGS_ENABLE_SCREEN_CAPTURE_DESCRIPTION,
1225 kOsDesktop, 1235 kOsDesktop,
1226 SINGLE_VALUE_TYPE(switches::kEnableUserMediaScreenCapturing) 1236 SINGLE_VALUE_TYPE(switches::kEnableUserMediaScreenCapturing)
1227 }, 1237 },
1228 #if defined(OS_MACOSX) 1238 #if defined(OS_MACOSX)
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
1506 // visible on Win/Mac/CrOS but not on Linux GTK, which would be confusing. 1516 // visible on Win/Mac/CrOS but not on Linux GTK, which would be confusing.
1507 // TODO(mgiuca): Remove the #if when Aura is the default on Linux. 1517 // TODO(mgiuca): Remove the #if when Aura is the default on Linux.
1508 "enable-app-list", 1518 "enable-app-list",
1509 IDS_FLAGS_ENABLE_APP_LIST_NAME, 1519 IDS_FLAGS_ENABLE_APP_LIST_NAME,
1510 IDS_FLAGS_ENABLE_APP_LIST_DESCRIPTION, 1520 IDS_FLAGS_ENABLE_APP_LIST_DESCRIPTION,
1511 kOsLinux, 1521 kOsLinux,
1512 SINGLE_VALUE_TYPE(switches::kEnableAppList) 1522 SINGLE_VALUE_TYPE(switches::kEnableAppList)
1513 }, 1523 },
1514 #endif 1524 #endif
1515 { 1525 {
1516 "disable-app-list-folder-ui",
1517 IDS_FLAGS_DISABLE_APP_LIST_FOLDER,
1518 IDS_FLAGS_DISABLE_APP_LIST_FOLDER_DESCRIPTION,
1519 kOsWin | kOsLinux | kOsCrOS,
1520 SINGLE_VALUE_TYPE(app_list::switches::kDisableFolderUI)
1521 },
1522 {
1523 "disable-app-list-voice-search", 1526 "disable-app-list-voice-search",
1524 IDS_FLAGS_DISABLE_APP_LIST_VOICE_SEARCH, 1527 IDS_FLAGS_DISABLE_APP_LIST_VOICE_SEARCH,
1525 IDS_FLAGS_DISABLE_APP_LIST_VOICE_SEARCH_DESCRIPTION, 1528 IDS_FLAGS_DISABLE_APP_LIST_VOICE_SEARCH_DESCRIPTION,
1526 kOsCrOS, 1529 kOsCrOS,
1527 SINGLE_VALUE_TYPE(app_list::switches::kDisableVoiceSearch) 1530 SINGLE_VALUE_TYPE(app_list::switches::kDisableVoiceSearch)
1528 }, 1531 },
1529 { 1532 {
1530 "enable-app-list-hotword-always-on", 1533 "enable-app-list-hotword-always-on",
1531 IDS_FLAGS_ENABLE_APP_LIST_HOTWORD_ALWAYS_ON, 1534 IDS_FLAGS_ENABLE_APP_LIST_HOTWORD_ALWAYS_ON,
1532 IDS_FLAGS_ENABLE_APP_LIST_HOTWORD_ALWAYS_ON_DESCRIPTION, 1535 IDS_FLAGS_ENABLE_APP_LIST_HOTWORD_ALWAYS_ON_DESCRIPTION,
(...skipping 822 matching lines...) Expand 10 before | Expand all | Expand 10 after
2355 } 2358 }
2356 2359
2357 const Experiment* GetExperiments(size_t* count) { 2360 const Experiment* GetExperiments(size_t* count) {
2358 *count = num_experiments; 2361 *count = num_experiments;
2359 return experiments; 2362 return experiments;
2360 } 2363 }
2361 2364
2362 } // namespace testing 2365 } // namespace testing
2363 2366
2364 } // namespace about_flags 2367 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698