Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 222553003: Disable AppList sync by default on non Chrome OS (Closed)

Created:
6 years, 8 months ago by stevenjb
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tim+watch_chromium.org, tfarina, haitaol+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, maniscalco+watch_chromium.org, Albert Bodenhamer
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix OSes in about_flags #

Patch Set 3 : Fix tests #

Patch Set 4 : Better fix for tests, about_flags #

Patch Set 5 : Elim --disable-app-list-folder-ui #

Total comments: 2

Patch Set 6 : Update enable-sync-app-list description #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -47 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 6 3 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 2 3 4 5 6 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/app_list/app_list_switches.h View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M ui/app_list/app_list_switches.cc View 1 2 3 4 2 chunks +18 lines, -7 lines 0 comments Download
M ui/app_list/views/apps_grid_view_unittest.cc View 1 2 3 4 8 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
stevenjb
About to test on Windows, but please take a look when you can.
6 years, 8 months ago (2014-04-02 18:16:03 UTC) #1
jennyz
lgtm
6 years, 8 months ago (2014-04-02 18:31:34 UTC) #2
stevenjb
Had to fix a few tests, PTAL
6 years, 8 months ago (2014-04-02 22:33:44 UTC) #3
jennyz
lgtm
6 years, 8 months ago (2014-04-02 23:15:08 UTC) #4
xiyuan
lgtm
6 years, 8 months ago (2014-04-02 23:21:12 UTC) #5
stevenjb
+calamity@
6 years, 8 months ago (2014-04-02 23:23:52 UTC) #6
stevenjb
OK, now with better about_flags and test fixes from https://codereview.chromium.org/212223012/ (thanks calamaty@) PTAL
6 years, 8 months ago (2014-04-03 00:36:02 UTC) #7
stevenjb
I realized that maintaining --disable-app-list-folder-ui is confusing and problematic at this point so I eliminated ...
6 years, 8 months ago (2014-04-03 00:47:41 UTC) #8
xiyuan
On 2014/04/03 00:47:41, stevenjb wrote: > I realized that maintaining --disable-app-list-folder-ui is confusing and > ...
6 years, 8 months ago (2014-04-03 00:56:01 UTC) #9
calamity
lgtm. https://codereview.chromium.org/222553003/diff/80001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/222553003/diff/80001/chrome/app/generated_resources.grd#newcode6613 chrome/app/generated_resources.grd:6613: + Enable App Launcher sync. nit: This description ...
6 years, 8 months ago (2014-04-03 01:07:29 UTC) #10
stevenjb
https://codereview.chromium.org/222553003/diff/80001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/222553003/diff/80001/chrome/app/generated_resources.grd#newcode6613 chrome/app/generated_resources.grd:6613: + Enable App Launcher sync. On 2014/04/03 01:07:30, calamity ...
6 years, 8 months ago (2014-04-03 01:17:33 UTC) #11
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 8 months ago (2014-04-03 06:33:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/222553003/100001
6 years, 8 months ago (2014-04-03 06:33:47 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:12:50 UTC) #14
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:12:51 UTC) #15
stevenjb
6 years, 8 months ago (2014-04-03 16:42:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #7 manually as r261445 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698