Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2225523002: Correctly restore fullscreen window bounds when leaving overview mode. (Closed)

Created:
4 years, 4 months ago by hariank
Modified:
4 years, 4 months ago
Reviewers:
reveman, oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly restore fullscreen window bounds when leaving overview mode. In WindowSelector's OnDisplayMetricsChanged, reposition windows only if a metric other than the work area is changed. BUG=634489 Committed: https://crrev.com/52d3a47c75a47c5e8b1e424d53b48401cd50dbdd Cr-Commit-Position: refs/heads/master@{#410393}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Correctly restore fullscreen window bounds when leaving overview mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ash/common/wm/overview/window_selector.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
hariank
Hi, please review this small change. Thanks!
4 years, 4 months ago (2016-08-05 22:18:00 UTC) #3
oshima
lgtm with a nit https://codereview.chromium.org/2225523002/diff/1/ash/common/wm/overview/window_selector.cc File ash/common/wm/overview/window_selector.cc (right): https://codereview.chromium.org/2225523002/diff/1/ash/common/wm/overview/window_selector.cc#newcode556 ash/common/wm/overview/window_selector.cc:556: // If only the work ...
4 years, 4 months ago (2016-08-05 23:18:00 UTC) #8
reveman
lgtm
4 years, 4 months ago (2016-08-08 16:41:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225523002/20001
4 years, 4 months ago (2016-08-08 17:13:31 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-08 18:05:05 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 18:07:50 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/52d3a47c75a47c5e8b1e424d53b48401cd50dbdd
Cr-Commit-Position: refs/heads/master@{#410393}

Powered by Google App Engine
This is Rietveld 408576698