net/cert/internal/path_builder_pkits_unittest.cc - Issue 2225493003: Don't treat trust anchors as certificates during path building.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/path_builder_pkits_unittest.cc

Issue 2225493003: Don't treat trust anchors as certificates during path building. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix components_unittests compile (hopefully) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/cert/internal/path_builder.cc ('K') | « net/cert/internal/path_builder.cc ('k') | net/cert/internal/path_builder_unittest.cc » ('j') | net/cert/internal/path_builder_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/cert/internal/path_builder_pkits_unittest.cc

diff --git a/net/cert/internal/path_builder_pkits_unittest.cc b/net/cert/internal/path_builder_pkits_unittest.cc

index a046d1cfe3029b1ae39374e89d3423c8e96b5e27..674a0ba21b6faf6d171226d128a7b11ff63e219a 100644

--- a/net/cert/internal/path_builder_pkits_unittest.cc

+++ b/net/cert/internal/path_builder_pkits_unittest.cc

@@ -67,7 +67,9 @@ class PathBuilderPkitsTestDelegate {

// First entry in the PKITS chain is the trust anchor.

// TODO(mattm): test with all possible trust anchors in the trust store?

TrustStore trust_store;

- trust_store.AddTrustedCertificate(certs[0]);

+ auto trust_anchor =

+ TrustAnchor::CreateFromCertificateNoConstraints(certs[0]);

+ trust_store.AddTrustAnchor(std::move(trust_anchor));

// TODO(mattm): test with other irrelevant certs in cert_issuer_sources?

CertIssuerSourceStatic cert_issuer_source;

« net/cert/internal/path_builder.cc ('K') | « net/cert/internal/path_builder.cc ('k') | net/cert/internal/path_builder_unittest.cc » ('j') | net/cert/internal/path_builder_unittest.cc » ('J')