Don't treat trust anchors as certificates during path building.

net/cert/internal/path_builder.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_INTERNAL_PATH_BUILDER_H_
 #define NET_CERT_INTERNAL_PATH_BUILDER_H_
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_export.h"
 #include "net/cert/internal/completion_status.h"
 #include "net/cert/internal/parsed_certificate.h"
+#include "net/cert/internal/trust_store.h"
 #include "net/der/input.h"
 #include "net/der/parse_values.h"
 
 namespace net {
 
 namespace der {
 struct GeneralizedTime;
 }
 
 class CertPathIter;
 class CertIssuerSource;
-class TrustStore;
 class SignaturePolicy;
 
+// CertPath describes a chain of certificates in the "forward" direction.
+//
+// By convention:
+//   certs[0] is the target certificate
+//   certs[i] was issued by certs[i+1]
+//   certs.back() was issued by trust_anchor
+struct NET_EXPORT CertPath {
+  CertPath();
+  ~CertPath();
+
+  scoped_refptr<TrustAnchor> trust_anchor;
+
+  // Path in the forward direction (path[0] is the target cert).
+  ParsedCertificateList certs;
+
+  // Resets the path to empty path (same as if default constructed).
+  void Clear();
+
+  // Returns true if the path is empty.
+  bool IsEmpty() const;
+};
+
 // Checks whether a certificate is trusted by building candidate paths to trust
 // anchors and verifying those paths according to RFC 5280. Each instance of
 // CertPathBuilder is used for a single verification.
 //
 // WARNING: This implementation is currently experimental.  Consult an OWNER
 // before using it.
 class NET_EXPORT CertPathBuilder {
  public:
   // Represents a single candidate path that was built.
   struct NET_EXPORT ResultPath {
     ResultPath();
     ~ResultPath();
 
     // Returns true if this path was successfully verified.
     bool is_success() const { return error == OK; }
 
+    // The trust anchor found for this path. May be nullptr if !is_success()
+    // and the path did not chain up to an anchor.
     // The candidate path, in forward direction.
     //   * path[0] is the target certificate.
     //   * path[i+1] is a candidate issuer of path[i]. The subject matches
     //   path[i]'s issuer, but nothing else is guaranteed unless is_success() is
     //   true.
-    //   * path[N-1] will be a trust anchor if is_success() is true, otherwise
-    //   it may or may not be a trust anchor.
-    ParsedCertificateList path;
+    CertPath path;
 
     // A net error code result of attempting to verify this path.
     // TODO(mattm): may want to have an independent result enum, which caller
     // can map to a net error if they want.
     int error = ERR_UNEXPECTED;
   };
 
   // Provides the overall result of path building. This includes the paths that
   // were attempted.
   struct NET_EXPORT Result {
@@ skipping 72 matching lines @@
     STATE_GET_NEXT_PATH,
     STATE_GET_NEXT_PATH_COMPLETE,
   };
 
   CompletionStatus DoLoop(bool allow_async);
 
   CompletionStatus DoGetNextPath(bool allow_async);
   void HandleGotNextPath();
   CompletionStatus DoGetNextPathComplete();
 
-  void AddResultPath(const ParsedCertificateList& path, bool is_success);
+  void AddResultPath(const CertPath& path, bool is_success);
 
   base::Closure callback_;
 
   std::unique_ptr<CertPathIter> cert_path_iter_;
-  const TrustStore* trust_store_;
   const SignaturePolicy* signature_policy_;
   const der::GeneralizedTime time_;
 
   // Stores the next complete path to attempt verification on. This is filled in
   // by |cert_path_iter_| during the STATE_GET_NEXT_PATH step, and thus should
   // only be accessed during the STATE_GET_NEXT_PATH_COMPLETE step.
   // (Will be empty if all paths have been tried, otherwise will be a candidate
-  // path starting with the target cert and ending with a trust anchor.)
-  ParsedCertificateList next_path_;
+  // path starting with the target cert and ending with a
+  // certificate issued by trust anchor.)
+  CertPath next_path_;
   State next_state_;
 
   Result* out_result_;
 
   DISALLOW_COPY_AND_ASSIGN(CertPathBuilder);
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_INTERNAL_PATH_BUILDER_H_