Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: net/cert/internal/path_builder_verify_certificate_chain_unittest.cc

Issue 2225493003: Don't treat trust anchors as certificates during path building. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address moar feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/cert/internal/path_builder_unittest.cc ('k') | net/cert/internal/trust_store.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/internal/path_builder.h" 5 #include "net/cert/internal/path_builder.h"
6 6
7 #include "net/cert/internal/cert_issuer_source_static.h" 7 #include "net/cert/internal/cert_issuer_source_static.h"
8 #include "net/cert/internal/signature_policy.h" 8 #include "net/cert/internal/signature_policy.h"
9 #include "net/cert/internal/trust_store.h" 9 #include "net/cert/internal/trust_store.h"
10 #include "net/cert/internal/verify_certificate_chain_typed_unittest.h" 10 #include "net/cert/internal/verify_certificate_chain_typed_unittest.h"
11 11
12 namespace net { 12 namespace net {
13 13
14 namespace { 14 namespace {
15 15
16 class PathBuilderDelegate { 16 class PathBuilderDelegate {
17 public: 17 public:
18 static void Verify(const ParsedCertificateList& chain, 18 static void Verify(const ParsedCertificateList& chain,
19 const ParsedCertificateList& roots, 19 const TrustAnchors& anchors,
20 const der::GeneralizedTime& time, 20 const der::GeneralizedTime& time,
21 bool expected_result) { 21 bool expected_result) {
22 SimpleSignaturePolicy signature_policy(1024); 22 SimpleSignaturePolicy signature_policy(1024);
23 ASSERT_FALSE(chain.empty()); 23 ASSERT_FALSE(chain.empty());
24 24
25 TrustStore trust_store; 25 TrustStore trust_store;
26 for (const auto& root : roots) 26 for (const auto& anchor : anchors)
27 trust_store.AddTrustedCertificate(root); 27 trust_store.AddTrustAnchor(anchor);
28 28
29 CertIssuerSourceStatic intermediate_cert_issuer_source; 29 CertIssuerSourceStatic intermediate_cert_issuer_source;
30 for (size_t i = 1; i < chain.size(); ++i) 30 for (size_t i = 1; i < chain.size(); ++i)
31 intermediate_cert_issuer_source.AddCert(chain[i]); 31 intermediate_cert_issuer_source.AddCert(chain[i]);
32 32
33 CertPathBuilder::Result result; 33 CertPathBuilder::Result result;
34 // First cert in the |chain| is the target. 34 // First cert in the |chain| is the target.
35 CertPathBuilder path_builder(chain.front(), &trust_store, &signature_policy, 35 CertPathBuilder path_builder(chain.front(), &trust_store, &signature_policy,
36 time, &result); 36 time, &result);
37 path_builder.AddCertIssuerSource(&intermediate_cert_issuer_source); 37 path_builder.AddCertIssuerSource(&intermediate_cert_issuer_source);
38 38
39 CompletionStatus rv = path_builder.Run(base::Closure()); 39 CompletionStatus rv = path_builder.Run(base::Closure());
40 EXPECT_EQ(CompletionStatus::SYNC, rv); 40 EXPECT_EQ(CompletionStatus::SYNC, rv);
41 41
42 EXPECT_EQ(expected_result, result.is_success()); 42 EXPECT_EQ(expected_result, result.is_success());
43 } 43 }
44 }; 44 };
45 45
46 } // namespace 46 } // namespace
47 47
48 INSTANTIATE_TYPED_TEST_CASE_P(PathBuilder, 48 INSTANTIATE_TYPED_TEST_CASE_P(PathBuilder,
49 VerifyCertificateChainSingleRootTest, 49 VerifyCertificateChainSingleRootTest,
50 PathBuilderDelegate); 50 PathBuilderDelegate);
51 51
52 INSTANTIATE_TYPED_TEST_CASE_P(PathBuilder, 52 INSTANTIATE_TYPED_TEST_CASE_P(PathBuilder,
53 VerifyCertificateChainNonSingleRootTest, 53 VerifyCertificateChainNonSingleRootTest,
54 PathBuilderDelegate); 54 PathBuilderDelegate);
55 55
56 } // namespace net 56 } // namespace net
OLDNEW
« no previous file with comments | « net/cert/internal/path_builder_unittest.cc ('k') | net/cert/internal/trust_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698