Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2225453002: Revert of Don't IAT patch SetUnhandledExceptionFilter when ASan is active (Closed)

Created:
4 years, 4 months ago by Reid Kleckner
Modified:
4 years, 4 months ago
CC:
chromium-reviews, pennymac+watch_chromium.org, caitkp+watch_chromium.org, penny
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't IAT patch SetUnhandledExceptionFilter when ASan is active (patchset #1 id:1 of https://codereview.chromium.org/2220583002/ ) Reason for revert: This causes crashpad to emit "haven't called UseHandler()" errors later. Original issue's description: > Don't IAT patch SetUnhandledExceptionFilter when ASan is active > > ASan installs its own exception filter that ClusterFuzz needs to see. > > R=robertshield@chromium.org,inferno@chromium.org > BUG=626373 > > Committed: https://crrev.com/3894e46c8c2702e12d2ddec12f186d7c1cf5c412 > Cr-Commit-Position: refs/heads/master@{#410077} TBR=inferno@chromium.org,robertshield@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626373 Committed: https://crrev.com/07928da2532a9a7d1149d0878d0931dd209f0d3c Cr-Commit-Position: refs/heads/master@{#410106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome_elf/chrome_elf_main.cc View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Reid Kleckner
Created Revert of Don't IAT patch SetUnhandledExceptionFilter when ASan is active
4 years, 4 months ago (2016-08-05 18:00:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225453002/1
4 years, 4 months ago (2016-08-05 18:00:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 18:01:14 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/07928da2532a9a7d1149d0878d0931dd209f0d3c Cr-Commit-Position: refs/heads/master@{#410106}
4 years, 4 months ago (2016-08-05 18:03:34 UTC) #6
aarya
4 years, 4 months ago (2016-08-05 18:05:07 UTC) #8
inferno
4 years, 4 months ago (2016-08-06 00:45:40 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2217833004/ by inferno@chromium.org.

The reason for reverting is: This patch didn't impact Crashpad..

Powered by Google App Engine
This is Rietveld 408576698