Makes chrome://omnibox use mojo

Makes chrome://omnibox use mojo

For the time being I'm moving chrome://omnibox behind USE_MOJO. Dave
has a patch out to enable USE_MOJO for Mac, which means it's only
android that won't have it for the time being.

BUG=none
TEST=none
R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262176

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267414

[sky, 2014-04-02 17:54:10]

Ok, this is ready for review for reals now.

https://codereview.chromium.org/222543004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/omnibox/omnibox.js (right):

https://codereview.chromium.org/222543004/diff/20001/chrome/browser/resources...
chrome/browser/resources/omnibox/omnibox.js:25: var connection;
I think this file can be restructured quite a bit. In particular all of these
functions should likely be moved into the object. I'm hoping to do that
separately.

[darin (slow to review), 2014-04-07 14:35:26]

LGTM

https://codereview.chromium.org/222543004/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/omnibox/omnibox.mojom (right):

https://codereview.chromium.org/222543004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/omnibox/omnibox.mojom:1: module chrome {
nit: add a license header

https://codereview.chromium.org/222543004/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc (right):

https://codereview.chromium.org/222543004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc:46: input.size());
nit: consider passing |buf| to each of the Builder's constructors. this is a
minor optimization. (we might want to consider doing away with this feature of
TypeConverter.)

https://codereview.chromium.org/222543004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc:91:
builder.set_duplicates(static_cast<int>(input.duplicate_matches.size()));
nit: you might want to be explicit here: int -> int32_t?

[sky, 2014-04-07 14:53:23]

https://codereview.chromium.org/222543004/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/omnibox/omnibox.mojom (right):

https://codereview.chromium.org/222543004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/omnibox/omnibox.mojom:1: module chrome {
On 2014/04/07 14:35:26, darin wrote:
> nit: add a license header

Done.

https://codereview.chromium.org/222543004/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc (right):

https://codereview.chromium.org/222543004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc:46: input.size());
On 2014/04/07 14:35:26, darin wrote:
> nit: consider passing |buf| to each of the Builder's constructors. this is a
> minor optimization. (we might want to consider doing away with this feature of
> TypeConverter.)

Done.

https://codereview.chromium.org/222543004/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc:91:
builder.set_duplicates(static_cast<int>(input.duplicate_matches.size()));
On 2014/04/07 14:35:26, darin wrote:
> nit: you might want to be explicit here: int -> int32_t?

Done.

[sky, 2014-04-07 14:53:35]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-04-07 14:53:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/222543004/80001

[commit-bot: I haz the power, 2014-04-07 15:35:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-07 15:35:16]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_compile_dbg

[sky, 2014-04-07 17:02:25]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-04-07 17:02:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/222543004/100001

[commit-bot: I haz the power, 2014-04-07 19:24:29]

Change committed as 262176

[sky, 2014-04-22 20:06:28]

This was reverted because of leaks in mojo. Those have since been fixed, so I'm
going to try landing again. Patchset 7 is the revert and 8 the single fix I had
to make to this (remove dependency on mojo_system due to other changes).

I'm going to try and reland now.

[sky, 2014-04-22 20:06:35]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-04-22 20:07:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/222543004/140001

[commit-bot: I haz the power, 2014-04-22 21:20:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-22 21:20:46]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[sky, 2014-04-30 19:44:38]

Now that all the leaks/bugs on the mojo side have been fixed I'm going to land
this again.

[sky, 2014-04-30 19:44:43]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-04-30 19:46:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/222543004/180001

[commit-bot: I haz the power, 2014-05-01 04:11:51]

Change committed as 267414