Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 222543003: Refactor the way page_set is checked in test_runner and record_wprd (Closed)

Created:
6 years, 8 months ago by nednguyen
Modified:
6 years, 8 months ago
Reviewers:
tonyg, dtu, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Refactor the way page_set is checked in test_runner and record_wprd BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/telemetry/telemetry/page/record_wpr.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/test_runner.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
nednguyen
6 years, 8 months ago (2014-04-02 17:43:11 UTC) #1
tonyg
lgtm
6 years, 8 months ago (2014-04-02 22:20:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/222543003/1
6 years, 8 months ago (2014-04-02 22:22:32 UTC) #3
dtu
lgtm
6 years, 8 months ago (2014-04-02 23:42:21 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 08:32:44 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 08:32:45 UTC) #6
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 8 months ago (2014-04-03 12:47:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/222543003/1
6 years, 8 months ago (2014-04-03 12:47:10 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 14:41:00 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 14:41:01 UTC) #10
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 8 months ago (2014-04-03 14:56:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/222543003/1
6 years, 8 months ago (2014-04-03 14:56:49 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 15:00:45 UTC) #13
Message was sent while issue was closed. 
Change committed as 261393

Powered by Google App Engine
This is Rietveld 408576698