Make the AstValueFactory more efficient and less memory hungry

Make the AstValueFactory more efficient and less memory hungry

This makes strings_ and values_ in AstValueFactory a linked list through the AstString and AstValue objects. Additionally the CL computes whether strings are convertible to array indexes directly using the AstString's hash + literal bytes just as Name does, rather than indirecting over name if available.

BUG=

Committed: https://crrev.com/cbe5d41d88f35dc8ee29d2e0f9ce739d9e132481
Cr-Commit-Position: refs/heads/master@{#38536}

[Toon Verwaest, 2016-08-09 15:22:36]

verwaest@chromium.org changed reviewers:
+ marja@chromium.org

[Toon Verwaest, 2016-08-09 15:22:36]

ptal

[marja, 2016-08-10 08:33:17]

lgtm

https://codereview.chromium.org/2225423002/diff/1/src/ast/ast-value-factory.cc
File src/ast/ast-value-factory.cc (right):

https://codereview.chromium.org/2225423002/diff/1/src/ast/ast-value-factory.c...
src/ast/ast-value-factory.cc:110: if ((hash_ & Name::kIsNotArrayIndexMask) != 0)
return false;
I was trying to follow which part sets this, and it was kinda far away. Could
you add a comment here, something like "kIsNotArrayIndexMap is set by
StringHasher."

[rmcilroy, 2016-08-10 11:12:57]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2016-08-10 11:12:58]

LGTM, thanks!

https://codereview.chromium.org/2225423002/diff/60001/src/ast/ast.h
File src/ast/ast.h (right):

https://codereview.chromium.org/2225423002/diff/60001/src/ast/ast.h#newcode1197
src/ast/ast.h:1197: // kAllowed or kDisallowed, although may be faster with
kAllowed.
Could you update the comment here please.

https://codereview.chromium.org/2225423002/diff/60001/src/ast/ast.h#newcode1743
src/ast/ast.h:1743: // kAllowed.
Could you update the comment here please.

[Toon Verwaest, 2016-08-10 11:21:20]

Done, thanks for the hint!

[Toon Verwaest, 2016-08-10 11:21:44]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-08-10 11:21:45]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org,
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2225423002/#ps80001
(title: "update comment")

[commit-bot: I haz the power, 2016-08-10 11:21:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 11:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 11:26:46]

Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[Toon Verwaest, 2016-08-10 11:29:44]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-08-10 11:29:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org, marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2225423002/#ps100001
(title: "Undo union since windows")

[commit-bot: I haz the power, 2016-08-10 11:29:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Toon Verwaest, 2016-08-10 11:39:38]

Description was changed from

==========
Make the AstValueFactory more efficient and less memory hungry

This makes strings_ and values_ in AstValueFactory a linked list through the
AstString and AstValue objects. Those objects reuse the Handle<> field while
uninternalized as the next_ pointer. Additionally the CL computes whether
strings are convertible to array indexes directly using the AstString's hash +
literal bytes just as Name does, rather than indirecting over name if available.

BUG=
==========

to

==========
Make the AstValueFactory more efficient and less memory hungry

This makes strings_ and values_ in AstValueFactory a linked list through the
AstString and AstValue objects. Additionally the CL computes whether strings are
convertible to array indexes directly using the AstString's hash + literal bytes
just as Name does, rather than indirecting over name if available.

BUG=
==========

[commit-bot: I haz the power, 2016-08-10 11:55:04]

Description was changed from

==========
Make the AstValueFactory more efficient and less memory hungry

This makes strings_ and values_ in AstValueFactory a linked list through the
AstString and AstValue objects. Additionally the CL computes whether strings are
convertible to array indexes directly using the AstString's hash + literal bytes
just as Name does, rather than indirecting over name if available.

BUG=
==========

to

==========
Make the AstValueFactory more efficient and less memory hungry

This makes strings_ and values_ in AstValueFactory a linked list through the
AstString and AstValue objects. Additionally the CL computes whether strings are
convertible to array indexes directly using the AstString's hash + literal bytes
just as Name does, rather than indirecting over name if available.

BUG=
==========

[commit-bot: I haz the power, 2016-08-10 11:55:06]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-10 11:55:24]

Description was changed from

==========
Make the AstValueFactory more efficient and less memory hungry

This makes strings_ and values_ in AstValueFactory a linked list through the
AstString and AstValue objects. Additionally the CL computes whether strings are
convertible to array indexes directly using the AstString's hash + literal bytes
just as Name does, rather than indirecting over name if available.

BUG=
==========

to

==========
Make the AstValueFactory more efficient and less memory hungry

This makes strings_ and values_ in AstValueFactory a linked list through the
AstString and AstValue objects. Additionally the CL computes whether strings are
convertible to array indexes directly using the AstString's hash + literal bytes
just as Name does, rather than indirecting over name if available.

BUG=

Committed: https://crrev.com/cbe5d41d88f35dc8ee29d2e0f9ce739d9e132481
Cr-Commit-Position: refs/heads/master@{#38536}
==========

[commit-bot: I haz the power, 2016-08-10 11:55:25]

Patchset 6 (id:??) landed as
https://crrev.com/cbe5d41d88f35dc8ee29d2e0f9ce739d9e132481
Cr-Commit-Position: refs/heads/master@{#38536}