UMA data collector for cross-site documents(XSD)

content/renderer/render_frame_impl.cc

Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index c90f88800f0f40bc6375f9588afe50958b8ee36e..ad8f702f58ad6d529f31b102da00cfbb9d3e4e3a 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -46,6 +46,7 @@
 #include "third_party/WebKit/public/web/WebStorageQuotaCallbacks.h"
 #include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
 #include "third_party/WebKit/public/web/WebView.h"
+#include "webkit/child/site_isolation_policy.h"
 #include "webkit/child/weburlresponse_extradata_impl.h"
 
 using WebKit::WebDataSource;
@@ -72,6 +73,7 @@ using base::Time;
 using base::TimeDelta;
 
 using webkit_glue::WebURLResponseExtraDataImpl;
+using webkit_glue::SiteIsolationPolicy;

[Charlie Reis, 2013/08/07 21:02:02]

nit: Alphabetical order.

[dsjang, 2013/08/08 21:21:01]

Done.

 
 namespace content {
 
@@ -377,6 +379,8 @@ void RenderFrameImpl::didFailProvisionalLoad(
   // * MaybeLoadAlternateErrorPage
   // * LoadNavigationErrorPage
   render_view_->didFailProvisionalLoad(frame, error);
+
+  SiteIsolationPolicy::DidFinishResourceLoadForUrl(error.unreachableURL);
 }
 
 void RenderFrameImpl::didCommitProvisionalLoad(WebKit::WebFrame* frame,
@@ -446,6 +450,8 @@ void RenderFrameImpl::didFailLoad(WebKit::WebFrame* frame,
                                   const WebKit::WebURLError& error) {
   // TODO(nasko): Move implementation here. No state needed.
   render_view_->didFailLoad(frame, error);
+
+  SiteIsolationPolicy::DidFinishResourceLoadForUrl(error.unreachableURL);
 }
 
 void RenderFrameImpl::didFinishLoad(WebKit::WebFrame* frame) {
@@ -603,12 +609,19 @@ void RenderFrameImpl::willSendRequest(
 
   if (!render_view_->renderer_preferences_.enable_referrers)
     request.clearHTTPHeaderField("Referer");
+
+  SiteIsolationPolicy::WillSendRequest(identifier, request.targetType());
 }
 
 void RenderFrameImpl::didReceiveResponse(
     WebKit::WebFrame* frame,
     unsigned identifier,
     const WebKit::WebURLResponse& response) {
+
+  // It should be guaranteed that
+  // SiteIsolationPolicy::DidFinishLoading(response.url());

[Charlie Reis, 2013/08/07 21:02:02]

Maybe you can clarify the comment?  Do you mean that this needs to be matched by
a call to DidFinishLoading with the same URL as in the response?  Is that the
right method name?

[dsjang, 2013/08/08 21:21:01]

Done.

+  SiteIsolationPolicy::DidReceiveResponse(frame, identifier, response);
+
   // Only do this for responses that correspond to a provisional data source
   // of the top-most frame.  If we have a provisional data source, then we
   // can't have any sub-resources yet, so we know that this response must
@@ -658,6 +671,8 @@ void RenderFrameImpl::didFinishResourceLoad(WebKit::WebFrame* frame,
   // Needed methods:
   // * LoadNavigationErrorPage
   render_view_->didFinishResourceLoad(frame, identifier);
+
+  SiteIsolationPolicy::DidFinishResourceLoad(identifier);
 }
 
 void RenderFrameImpl::didLoadResourceFromMemoryCache(