UMA data collector for cross-site documents(XSD)

webkit/child/weburlloader_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // An implementation of WebURLLoader in terms of ResourceLoaderBridge.
 
 #include "webkit/child/weburlloader_impl.h"
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
@@ skipping 13 matching lines @@
 #include "third_party/WebKit/public/platform/WebURL.h"
 #include "third_party/WebKit/public/platform/WebURLError.h"
 #include "third_party/WebKit/public/platform/WebURLLoadTiming.h"
 #include "third_party/WebKit/public/platform/WebURLLoaderClient.h"
 #include "third_party/WebKit/public/platform/WebURLRequest.h"
 #include "third_party/WebKit/public/platform/WebURLResponse.h"
 #include "third_party/WebKit/public/web/WebSecurityPolicy.h"
 #include "webkit/child/ftp_directory_listing_response_delegate.h"
 #include "webkit/child/multipart_response_delegate.h"
 #include "webkit/child/resource_loader_bridge.h"
+#include "webkit/child/site_isolation_policy.h"

[darin (slow to review), 2013/08/14 05:23:27]

We are trying not to add more code to src/webkit/ as it is all intended to be
moved to src/content/, so this change is creating more work for someone.

Of course it would be a layering violation to call code from src/content/ in
src/webkit/.

One idea would be to move your metrics gathering to src/content/ entirely.  I
think you could easily move this code to
src/content/child/resource_dispatcher.cc, and then the site_isolation_policy
would be able to be src/content/ as well.

[dsjang, 2013/08/14 20:47:03]

Done.

 #include "webkit/child/webkitplatformsupport_impl.h"
 #include "webkit/child/weburlrequest_extradata_impl.h"
 #include "webkit/child/weburlresponse_extradata_impl.h"
 #include "webkit/common/resource_request_body.h"
 
 using base::Time;
 using base::TimeTicks;
 using WebKit::WebData;
 using WebKit::WebHTTPBody;
 using WebKit::WebHTTPHeaderVisitor;
@@ skipping 322 matching lines @@
   void HandleDataURL();
 
   WebURLLoaderImpl* loader_;
   WebURLRequest request_;
   WebURLLoaderClient* client_;
   WebReferrerPolicy referrer_policy_;
   scoped_ptr<ResourceLoaderBridge> bridge_;
   scoped_ptr<FtpDirectoryListingResponseDelegate> ftp_listing_delegate_;
   scoped_ptr<MultipartResponseDelegate> multipart_delegate_;
   scoped_ptr<ResourceLoaderBridge> completed_bridge_;
+
+  // TODO(dsjang): A temporary hack to connect the lastest response observed by

[darin (slow to review), 2013/08/14 05:23:27]

nit: lastest -> latest

[dsjang, 2013/08/14 20:47:03]

Done.

+  // OnReceiveResponse() and the data stream received by OnReceivedData(). We
+  // can use this information for actual blocking. We can move this to somewhere
+  // better than here for actual blocking in the renderer. Ultimately, the
+  // blocking code will be moved to the browser process.
+  WebURL response_url_;
 };
 
 WebURLLoaderImpl::Context::Context(WebURLLoaderImpl* loader)
     : loader_(loader),
       client_(NULL),
       referrer_policy_(WebKit::WebReferrerPolicyDefault) {
 }
 
 void WebURLLoaderImpl::Context::Cancel() {
   // The bridge will still send OnCompletedRequest, which will Release() us, so
@@ skipping 275 matching lines @@
     // code, nsMultiMixedConv::OnStartRequest throws an exception.
     if (!boundary.empty()) {
       multipart_delegate_.reset(
           new MultipartResponseDelegate(client_, loader_, response, boundary));
     }
   } else if (info.mime_type == "text/vnd.chromium.ftp-dir" &&
              !show_raw_listing) {
     ftp_listing_delegate_.reset(
         new FtpDirectoryListingResponseDelegate(client_, loader_, response));
   }
+
+  response_url_ = response.url();
 }
 
 void WebURLLoaderImpl::Context::OnDownloadedData(int len) {
   if (client_)
     client_->didDownloadData(loader_, len);
 }
 
 void WebURLLoaderImpl::Context::OnReceivedData(const char* data,
                                                int data_length,
                                                int encoded_data_length) {
   if (!client_)
     return;
 
   if (ftp_listing_delegate_) {
     // The FTP listing delegate will make the appropriate calls to
     // client_->didReceiveData and client_->didReceiveResponse.
     ftp_listing_delegate_->OnReceivedData(data, data_length);
   } else if (multipart_delegate_) {
     // The multipart delegate will make the appropriate calls to
     // client_->didReceiveData and client_->didReceiveResponse.
     multipart_delegate_->OnReceivedData(data, data_length, encoded_data_length);
   } else {
     client_->didReceiveData(loader_, data, data_length, encoded_data_length);
   }
+
+  // TODO(dsjang): This logging code is just temporary. There has to
+  // be a better way to connect the received data to the response_url
+  // than this.
+  SiteIsolationPolicy::DidReceiveData(data, data_length, response_url_);
 }
 
 void WebURLLoaderImpl::Context::OnReceivedCachedMetadata(
     const char* data, int len) {
   if (client_)
     client_->didReceiveCachedMetadata(loader_, data, len);
 }
 
 void WebURLLoaderImpl::Context::OnCompletedRequest(
     int error_code,
@@ skipping 15 matching lines @@
 
   if (client_) {
     if (error_code != net::OK) {
       client_->didFail(loader_, CreateError(request_.url(), error_code));
     } else {
       client_->didFinishLoading(
           loader_, (completion_time - TimeTicks()).InSecondsF());
     }
   }
 
+  // TODO(dsjang): This logging code is just temporary. There has to
+  // be a better way to connect the received data to the response_url
+  // than this.
+  SiteIsolationPolicy::DidFinishResourceLoadForUrl(response_url_);
+
   // We are done with the bridge now, and so we need to release the reference
   // to ourselves that we took on behalf of the bridge.  This may cause our
   // destruction.
   Release();
 }
 
 bool WebURLLoaderImpl::Context::CanHandleDataURL(const GURL& url) const {
   DCHECK(url.SchemeIs("data"));
 
   // Optimize for the case where we can handle a data URL locally.  We must
@@ skipping 104 matching lines @@
 
 void WebURLLoaderImpl::setDefersLoading(bool value) {
   context_->SetDefersLoading(value);
 }
 
 void WebURLLoaderImpl::didChangePriority(WebURLRequest::Priority new_priority) {
   context_->DidChangePriority(new_priority);
 }
 
 }  // namespace webkit_glue