UMA data collector for cross-site documents(XSD)

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "content/child/appcache_dispatcher.h"
 #include "content/child/fileapi/file_system_dispatcher.h"
@@ skipping 28 matching lines @@
 #include "third_party/WebKit/public/web/WebFileSystemCallbacks.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebNavigationPolicy.h"
 #include "third_party/WebKit/public/web/WebPlugin.h"
 #include "third_party/WebKit/public/web/WebPluginParams.h"
 #include "third_party/WebKit/public/web/WebSearchableFormData.h"
 #include "third_party/WebKit/public/web/WebSecurityOrigin.h"
 #include "third_party/WebKit/public/web/WebStorageQuotaCallbacks.h"
 #include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
 #include "third_party/WebKit/public/web/WebView.h"
+#include "webkit/child/site_isolation_policy.h"
 #include "webkit/child/weburlresponse_extradata_impl.h"
 
 using WebKit::WebDataSource;
 using WebKit::WebDocument;
 using WebKit::WebFileSystemCallbacks;
 using WebKit::WebFrame;
 using WebKit::WebNavigationPolicy;
 using WebKit::WebPluginParams;
 using WebKit::WebReferrerPolicy;
 using WebKit::WebSearchableFormData;
 using WebKit::WebSecurityOrigin;
 using WebKit::WebStorageQuotaCallbacks;
 using WebKit::WebString;
 using WebKit::WebURL;
 using WebKit::WebURLError;
 using WebKit::WebURLRequest;
 using WebKit::WebURLResponse;
 using WebKit::WebUserGestureIndicator;
 using WebKit::WebVector;
 using WebKit::WebView;
 
 using appcache::WebApplicationCacheHostImpl;
 using base::Time;
 using base::TimeDelta;
 
+using webkit_glue::SiteIsolationPolicy;
 using webkit_glue::WebURLResponseExtraDataImpl;
 
 namespace content {
 
 static RenderFrameImpl* (*g_create_render_frame_impl)(RenderViewImpl*, int32) =
     NULL;
 
 // static
 RenderFrameImpl* RenderFrameImpl::Create(
     RenderViewImpl* render_view,
@@ skipping 286 matching lines @@
 void RenderFrameImpl::didFailProvisionalLoad(
     WebKit::WebFrame* frame,
     const WebKit::WebURLError& error) {
   // TODO(nasko): Move implementation here. Needed state:
   // * page_id_
   // * pending_navigation_params_
   // Needed methods
   // * MaybeLoadAlternateErrorPage
   // * LoadNavigationErrorPage
   render_view_->didFailProvisionalLoad(frame, error);
+
+  SiteIsolationPolicy::DidFinishResourceLoadForUrl(error.unreachableURL);
 }
 
 void RenderFrameImpl::didCommitProvisionalLoad(WebKit::WebFrame* frame,
                                                bool is_new_navigation) {
   // TODO(nasko): Move implementation here. Needed state:
   // * page_id_
   // * next_page_id_
   // * history_list_offset_
   // * history_list_length_
   // * history_page_ids_
@@ skipping 49 matching lines @@
 void RenderFrameImpl::didHandleOnloadEvents(WebKit::WebFrame* frame) {
   // TODO(nasko): Move implementation here. Needed state:
   // * page_id_
   render_view_->didHandleOnloadEvents(frame);
 }
 
 void RenderFrameImpl::didFailLoad(WebKit::WebFrame* frame,
                                   const WebKit::WebURLError& error) {
   // TODO(nasko): Move implementation here. No state needed.
   render_view_->didFailLoad(frame, error);
+
+  SiteIsolationPolicy::DidFinishResourceLoadForUrl(error.unreachableURL);
 }
 
 void RenderFrameImpl::didFinishLoad(WebKit::WebFrame* frame) {
   // TODO(nasko): Move implementation here. No state needed, just observers
   // notification before sending message to the browser process.
   render_view_->didFinishLoad(frame);
 }
 
 void RenderFrameImpl::didNavigateWithinPage(WebKit::WebFrame* frame,
                                             bool is_new_navigation) {
@@ skipping 137 matching lines @@
         navigation_state->extra_headers().begin(),
         navigation_state->extra_headers().end(), "\n");
         i.GetNext(); ) {
       request.setHTTPHeaderField(WebString::fromUTF8(i.name()),
                                  WebString::fromUTF8(i.values()));
     }
   }
 
   if (!render_view_->renderer_preferences_.enable_referrers)
     request.clearHTTPHeaderField("Referer");
+
+  SiteIsolationPolicy::WillSendRequest(identifier, request.targetType());
 }
 
 void RenderFrameImpl::didReceiveResponse(
     WebKit::WebFrame* frame,
     unsigned identifier,
     const WebKit::WebURLResponse& response) {
+
+  // Calling this will do bookkeeping of an object related to the

[Charlie Reis, 2013/08/09 00:39:03]

will update bookkeeping related to the response for later use.

[dsjang, 2013/08/09 01:31:23]

Done.

+  // response for late uses. We have to make it sure to call either

[Charlie Reis, 2013/08/09 00:39:03]

make sure

[dsjang, 2013/08/09 01:31:23]

Done.

+  // SiteIsolationPolicy::DidFinishResourceLoad(identifier) or
+  // SiteIsolationPolicy::DidFinishResourceLoadForURL(response.url())
+  // to free the object.

[Charlie Reis, 2013/08/09 00:39:03]

free the bookkeeping data.

I think this whole comment block belongs on the
SiteIsolationPolicy::DidReceiveResponse declaration, rather than at the call
site.

[dsjang, 2013/08/09 01:31:23]

Done.

+  SiteIsolationPolicy::DidReceiveResponse(frame, identifier, response);
+
   // Only do this for responses that correspond to a provisional data source
   // of the top-most frame.  If we have a provisional data source, then we
   // can't have any sub-resources yet, so we know that this response must
   // correspond to a frame load.
   if (!frame->provisionalDataSource() || frame->parent())
     return;
 
   // If we are in view source mode, then just let the user see the source of
   // the server's error page.
   if (frame->isViewSourceModeEnabled())
@@ skipping 29 matching lines @@
   internal_data->set_use_error_page(true);
 }
 
 void RenderFrameImpl::didFinishResourceLoad(WebKit::WebFrame* frame,
                                             unsigned identifier) {
   // TODO(nasko): Move implementation here. Needed state:
   // * devtools_agent_
   // Needed methods:
   // * LoadNavigationErrorPage
   render_view_->didFinishResourceLoad(frame, identifier);
+
+  SiteIsolationPolicy::DidFinishResourceLoad(identifier);
 }
 
 void RenderFrameImpl::didLoadResourceFromMemoryCache(
     WebKit::WebFrame* frame,
     const WebKit::WebURLRequest& request,
     const WebKit::WebURLResponse& response) {
   // The recipients of this message have no use for data: URLs: they don't
   // affect the page's insecure content list and are not in the disk cache. To
   // prevent large (1M+) data: URLs from crashing in the IPC system, we simply
   // filter them out here.
@@ skipping 225 matching lines @@
 
 void RenderFrameImpl::didLoseWebGLContext(WebKit::WebFrame* frame,
                                           int arb_robustness_status_code) {
   Send(new ViewHostMsg_DidLose3DContext(
       GURL(frame->top()->document().securityOrigin().toString()),
       THREE_D_API_TYPE_WEBGL,
       arb_robustness_status_code));
 }
 
 }  // namespace content