content/test/data/cross_site_document_request_target.html - Issue 22254005: UMA data collector for cross-site documents(XSD)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/cross_site_document_request_target.html

Issue 22254005: UMA data collector for cross-site documents(XSD) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: blocking code gets simpler and testcase is moved to /content Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/test/data/cross_site_document_request.html ('K') | « content/test/data/cross_site_document_request.html ('k') | content/test/data/site_isolation/comment_js.html » ('j') | content/test/data/site_isolation/comment_js.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <!-- This page tests that the renderer process does not crash even the response
	Charlie Reis 2013/08/22 18:23:30 nit: Just move this text into the body of the page nit: Just move this text into the body of the page rather than in a comment. dsjang 2013/08/22 19:05:55 Done. Show quoted text On 2013/08/22 18:23:30, creis wrote: > nit: Just move this text into the body of the page rather than in a comment. Done.
	3 that it requested is blocked by SiteIsolationPolicy for various targets. This

	4 page should be loaded on a domain other than bar.com to be different from the

	5 requested resource here. -->

	6 <head>

	7 <!-- favicon -->

	8 <link rel="icon"

	9 type="image/png"

	10 href="http://bar.com/files/site_isolation/valid.html">

	11 <!-- css -->

	12 <link rel="stylesheet" type="text/css" href="http://bar.com/files/site_isolation /valid.html">

	13 <!-- script -->

	14 <script language="javascript" src="http://bar.com/files/site_isolation/valid.htm l"></script>

	15 </head>

	16 <body>

	17 <!-- image -->
	Charlie Reis 2013/08/22 18:23:30 nit: No need for the redundant HTML comment if you nit: No need for the redundant HTML comment if you label it in the body of the page. dsjang 2013/08/22 19:05:55 Done. Show quoted text On 2013/08/22 18:23:30, creis wrote: > nit: No need for the redundant HTML comment if you label it in the body of the > page. Done.
	18 image:<img src="http://bar.com/files/site_isolation/valid.html"></img><br/>

	19

	20 <!-- font -->

	21 font:

	22 <style media="screen" type="text/css">

	23 @font-face {

	24 font-family: "myfont";

	25 src: url("http://bar.com/files/site_isolation/valid.html") format('woff');

	26 }

	27 </style><br/>

	28

	29 <!-- The renderer creates an iframe for a file with .html extension, so this

	30 should be fixed later. -->
	Charlie Reis 2013/08/22 18:23:30 Can you clarify what "should be fixed" means? Can you clarify what "should be fixed" means? dsjang 2013/08/22 19:05:55 Done. Show quoted text On 2013/08/22 18:23:30, creis wrote: > Can you clarify what "should be fixed" means? Done.
	31 embed:<embed src="http://bar.com/files/site_isolation/valid.html"></embed><br/>

	32

	33 <!-- The renderer creates an iframe for a file with .html extension, so this

	34 should be fixed later. -->

	35 object:<object width="400" height="400"

	36 data="http://bar.com/files/site_isolation/valid.html"></object><br/>

	37

	38 </body>

	39 </html>

OLD	NEW