third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-post.html - Issue 2225383003: Origin header should be preserved in http requests made via OpenURL code path.

Unified Diff: third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-post.html

Issue 2225383003: Origin header should be preserved in http requests made via OpenURL code path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-get-expected.txt ('K') | « third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-get-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-post-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-post-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-post.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-post.html b/third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-post.html

index f90afd84535ccc2ddb6c4bde65115aabbf81f79f..c269711ae5d197d5f64f72b97eec761350d8487f 100644

--- a/third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-post.html

+++ b/third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-post.html

@@ -26,7 +26,7 @@ was propagated correctly.

<form

method="POST"

- action="https://localhost:8443/navigation/resources/form-target.pl"

+ action="http://localhost:8000/navigation/resources/form-target.pl"

Łukasz Anforowicz 2016/08/09 17:55:51 Non-https scheme means it is easier to manually re

jww 2016/08/09 22:38:23 Ack, and I suppose this is fine, although I don't

Łukasz Anforowicz 2016/08/10 00:03:19 Okay. FWIW, I authored the initial test (and can

jww 2016/08/10 00:44:53 Ah, that does make me feel better :-)

target="cross-site-frame">

Test field:

@@ -34,6 +34,6 @@ was propagated correctly.

</form>

<iframe

name="cross-site-frame"

- src="https://localhost:8443/navigation/resources/form-target.pl"></iframe>

+ src="http://localhost:8000/navigation/resources/form-target.pl"></iframe>

</body>

</html>