third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-get.html - Issue 2225383003: Origin header should be preserved in http requests made via OpenURL code path.

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-get.html

Issue 2225383003: Origin header should be preserved in http requests made via OpenURL code path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test doesn't depent on initial URI of the frame (as long as it is cross-site). Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/site-per-process ('k') | third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-get-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/navigation/resources/form-target.pl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 The test verifies that a form with target="crossSiteFrame" works fine	3 The test verifies that a form with target="crossSiteFrame" works fine

4 (especially in presence of out-of-process-iframes, aka OOPIFs, aka	4 (especially in presence of out-of-process-iframes, aka OOPIFs, aka

5 blink::RemoteFrames which are present in --site-per-process mode).	5 blink::RemoteFrames which are present in --site-per-process mode).

6	6

7 The test finishes successfully, if form-target.pl ends up calling	7 The test finishes successfully, if form-target.pl ends up calling

8 testRunner.notifyDone() after main frame calls testRuner.waitUntilDone	8 testRunner.notifyDone() after main frame calls testRuner.waitUntilDone

9 and submits the form. Expected test output helps verify that the	9 and submits the form. Expected test output helps verify that the

10 correct HTTP method was used and that test field's value from the form	10 correct HTTP method was used and that test field's value from the form

11 was propagated correctly.	11 was propagated correctly.

12 -->	12 -->

13 <html>	13 <html>

14 <script>	14 <script>

15 if (window.testRunner) {	15 if (window.testRunner) {

16 testRunner.dumpAsText();	16 testRunner.dumpAsText();

17 testRunner.dumpChildFramesAsText();	17 testRunner.dumpChildFramesAsText();

18 }	18 }

19	19

20 function onLoad() {	20 function onLoad() {

21 if (window.testRunner)	21 if (window.testRunner)

22 testRunner.waitUntilDone();	22 testRunner.waitUntilDone();

23 document.forms[0].submit();	23 document.forms[0].submit();

24 }	24 }

25 </script>	25 </script>

26 <body onload="onLoad();">	26 <body onload="onLoad();">

27 <form	27 <form

28 method="GET"	28 method="GET"

29 action="https://localhost:8443/navigation/resources/form-target.pl"	29 action="http://localhost:8000/navigation/resources/form-target.pl"
	jww 2016/08/09 22:38:23 Please make this port 8080 (or whatever the altern Please make this port 8080 (or whatever the alternate port is for testing). Especially in manual testing, it's easy to accidentally use 'localhost' instead of 127.0.0.1, and then you'll accidentally have same-origin. Having a different port makes it super explicit. Łukasz Anforowicz 2016/08/10 00:03:19 Good point. This (desire to avoid accidentally en Show quoted text On 2016/08/09 22:38:23, jww wrote: > Please make this port 8080 (or whatever the alternate port is for testing). > Especially in manual testing, it's easy to accidentally use 'localhost' instead > of 127.0.0.1, and then you'll accidentally have same-origin. Having a different > port makes it super explicit. Good point. This (desire to avoid accidentally ending up with same-origin) was actually one of the reasons why I initially went forward with "https" rather than "http". I've changed the port to 8080 and rerun the tests locally to update the expectation files. Done.
30 target="cross-site-frame">	30 target="cross-site-frame">

31 Test field:	31 Test field:

32 <input name="test-field" type="text" value="test-value">	32 <input name="test-field" type="text" value="test-value">

33 <input type="submit" value="Submit">	33 <input type="submit" value="Submit">

34 </form>	34 </form>

35 <iframe	35 <iframe

36 name="cross-site-frame"	36 name="cross-site-frame"

37 src="https://localhost:8443/navigation/resources/form-target.pl"></iframe>	37 src="http://localhost:8000/navigation/resources/otherpage.html"></iframe>

38 </body>	38 </body>

39 </html>	39 </html>

OLD	NEW