Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2225373002: Read zone() directly from parser_ in ParserTraits (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Read zone() directly from parser_ in ParserTraits BUG= Committed: https://crrev.com/2f6b26ed4545b2afe97b73f97938db56a98af822 Cr-Commit-Position: refs/heads/master@{#38493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/parsing/parser.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-09 11:53:11 UTC) #2
vogelheim
lgtm
4 years, 4 months ago (2016-08-09 11:55:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225373002/1
4 years, 4 months ago (2016-08-09 11:57:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 13:05:17 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 13:05:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f6b26ed4545b2afe97b73f97938db56a98af822
Cr-Commit-Position: refs/heads/master@{#38493}

Powered by Google App Engine
This is Rietveld 408576698