Recreate the WebData database on a catastrophic SQL error

components/webdata/common/web_database_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/webdata/common/web_database_service.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 116 matching lines @@
   loaded_callbacks_.push_back(callback);
 }
 
 void WebDatabaseService::RegisterDBErrorCallback(
     const DBLoadErrorCallback& callback) {
   error_callbacks_.push_back(callback);
 }
 
 void WebDatabaseService::OnDatabaseLoadDone(sql::InitStatus status,
                                             const std::string& diagnostics) {
-  if (status == sql::INIT_OK) {
+  // The INIT_OK_WITH_DATA_LOSS status is an initialization success but with
+  // suspected data loss, so we also run the error callbacks.
+  if (status != sql::INIT_OK) {
+    // Notify that the database load failed.
+    while (!error_callbacks_.empty()) {
+      // The profile error callback is a message box that runs in a nested run
+      // loop. While it's being displayed, other OnDatabaseLoadDone() will run
+      // (posted from WebDatabaseBackend::Delegate::DBLoaded()). We need to make
+      // sure that after the callback running the message box returns, it checks
+      // |error_callbacks_| before it accesses it.
+      DBLoadErrorCallback error_callback = error_callbacks_.back();
+      error_callbacks_.pop_back();
+      if (!error_callback.is_null())
+        error_callback.Run(status, diagnostics);
+    }
+  }
+
+  if (status == sql::INIT_OK || status == sql::INIT_OK_WITH_DATA_LOSS) {
     db_loaded_ = true;
 
-    for (const auto& loaded_callback : loaded_callbacks_) {
+    while (!loaded_callbacks_.empty()) {
+      DBLoadedCallback loaded_callback = loaded_callbacks_.back();
+      loaded_callbacks_.pop_back();
       if (!loaded_callback.is_null())
         loaded_callback.Run();
     }
-
-    loaded_callbacks_.clear();
-  } else {
-    // Notify that the database load failed.
-    for (const auto& error_callback : error_callbacks_) {
-      if (!error_callback.is_null())
-        error_callback.Run(status, diagnostics);
-    }
-
-    error_callbacks_.clear();
   }
 }