Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: src/gpu/vk/GrVkRenderTarget.cpp

Issue 2225303002: Add flag for window rectangles to GrRenderTarget (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/vk/GrVkRenderTarget.cpp
diff --git a/src/gpu/vk/GrVkRenderTarget.cpp b/src/gpu/vk/GrVkRenderTarget.cpp
index 83a4b44a59562e5d3fae11bc21260951dcb2f542..7a66d7ca93450045f7cd5176d79e77095c2d5eed 100644
--- a/src/gpu/vk/GrVkRenderTarget.cpp
+++ b/src/gpu/vk/GrVkRenderTarget.cpp
@@ -32,7 +32,7 @@ GrVkRenderTarget::GrVkRenderTarget(GrVkGpu* gpu,
: GrSurface(gpu, desc)
, GrVkImage(info, wrapped)
// for the moment we only support 1:1 color to stencil
- , GrRenderTarget(gpu, desc, kUnified_SampleConfig)
+ , GrRenderTarget(gpu, desc, ComputeFlags(/*???*/))
, fColorAttachmentView(colorAttachmentView)
, fMSAAImage(new GrVkImage(msaaInfo, GrVkImage::kNot_Wrapped))
, fResolveAttachmentView(resolveAttachmentView)
@@ -57,7 +57,7 @@ GrVkRenderTarget::GrVkRenderTarget(GrVkGpu* gpu,
: GrSurface(gpu, desc)
, GrVkImage(info, wrapped)
// for the moment we only support 1:1 color to stencil
- , GrRenderTarget(gpu, desc, kUnified_SampleConfig)
+ , GrRenderTarget(gpu, desc, ComputeFlags(/*???*/))
, fColorAttachmentView(colorAttachmentView)
, fMSAAImage(new GrVkImage(msaaInfo, GrVkImage::kNot_Wrapped))
, fResolveAttachmentView(resolveAttachmentView)
@@ -79,7 +79,7 @@ GrVkRenderTarget::GrVkRenderTarget(GrVkGpu* gpu,
GrVkImage::Wrapped wrapped)
: GrSurface(gpu, desc)
, GrVkImage(info, wrapped)
- , GrRenderTarget(gpu, desc, kUnified_SampleConfig)
+ , GrRenderTarget(gpu, desc, ComputeFlags(/*???*/))
, fColorAttachmentView(colorAttachmentView)
, fMSAAImage(nullptr)
, fResolveAttachmentView(nullptr)
@@ -100,7 +100,7 @@ GrVkRenderTarget::GrVkRenderTarget(GrVkGpu* gpu,
GrVkImage::Wrapped wrapped)
: GrSurface(gpu, desc)
, GrVkImage(info, wrapped)
- , GrRenderTarget(gpu, desc, kUnified_SampleConfig)
+ , GrRenderTarget(gpu, desc, ComputeFlags(/*???*/))
, fColorAttachmentView(colorAttachmentView)
, fMSAAImage(nullptr)
, fResolveAttachmentView(nullptr)
@@ -111,6 +111,10 @@ GrVkRenderTarget::GrVkRenderTarget(GrVkGpu* gpu,
this->createFramebuffer(gpu);
}
+constexpr GrRenderTarget::Flags GrVkRenderTarget::ComputeFlags(/*???*/) {
+ return true/*???*/ ? Flags::kOffscreen : Flags::kNone;
csmartdalton 2016/08/09 06:52:58 Can we deduce here whether the RT is offscreen?
+}
+
GrVkRenderTarget*
GrVkRenderTarget::Create(GrVkGpu* gpu,
SkBudgeted budgeted,
« no previous file with comments | « src/gpu/vk/GrVkRenderTarget.h ('k') | tests/ProxyTest.cpp » ('j') | tests/ProxyTest.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698