Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: pkg/custom_element/lib/custom_element.dart

Issue 22253002: fix packages for latest SDK changes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/mdv/lib/mdv.dart » ('j') | pkg/mdv/lib/mdv.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/custom_element/lib/custom_element.dart
diff --git a/pkg/custom_element/lib/custom_element.dart b/pkg/custom_element/lib/custom_element.dart
index 369501c69b8ea2ffcca0a75c727b94e9883b70b6..50cc1a6e373fdddfe85bbc85a2b0f0b5d67c6488 100644
--- a/pkg/custom_element/lib/custom_element.dart
+++ b/pkg/custom_element/lib/custom_element.dart
@@ -31,7 +31,7 @@ import 'src/custom_tag_name.dart';
void registerCustomElement(String localName, CustomElement create()) {
if (_customElements == null) {
_customElements = {};
- CustomElement.templateCreated.add(initCustomElements);
+ mdv.instanceCreated.add(initCustomElements);
// TODO(jmesserly): use MutationObserver to watch for inserts?
}
@@ -159,46 +159,6 @@ class CustomElement implements Element {
getShadowRoot(String componentName) => _generatedRoots[componentName];
-
- /**
- * *Warning*: This is an implementation helper for Custom Elements and
- * should not be used in your code.
- *
- * Clones the template, instantiates custom elements and hooks events, then
- * returns it.
- */
- DocumentFragment cloneTemplate(DocumentFragment shadowTemplate) {
- var result = shadowTemplate.clone(true);
- // TODO(jmesserly): should bindModel ensure this happens?
- TemplateElement.bootstrap(result);
- if (_templateCreated != null) {
- for (var callback in _templateCreated) callback(result);
- }
- return result;
- }
-
- // TODO(jmesserly): ideally this would be a stream, but they don't allow
- // reentrancy.
- static Set<DocumentFragmentCreated> _templateCreated;
-
- /**
- * *Warning*: This is an implementation helper for Custom Elements and
- * should not be used in your code.
- *
- * This event is fired whenever a template is instantiated via
- * [cloneTemplate] or via [Element.createInstance]
- */
- // TODO(jmesserly): This is a hack, and is neccesary for the polyfill
- // because custom elements are not upgraded during clone()
- static Set<DocumentFragmentCreated> get templateCreated {
- if (_templateCreated == null) {
- _templateCreated = new Set<DocumentFragmentCreated>();
- mdv.instanceCreated.listen((value) {
- for (var callback in _templateCreated) callback(value);
- });
- }
- return _templateCreated;
- }
/**
* Invoked when this component gets created.
* Note that [root] will be a [ShadowRoot] if the browser supports Shadow DOM.
@@ -230,7 +190,7 @@ class CustomElement implements Element {
host.createInstance(model, delegate);
createBinding(String name, model, String path) =>
host.createBinding(name, model, path);
- void bind(String name, model, String path) => host.bind(name, model, path);
+ bind(String name, model, String path) => host.bind(name, model, path);
void unbind(String name) => host.unbind(name);
void unbindAll() => host.unbindAll();
get bindings => host.bindings;
@@ -659,8 +619,6 @@ class CustomElement implements Element {
}
-typedef DocumentFragmentCreated(DocumentFragment fragment);
-
Map<String, Function> _customElements;
void _initCustomElement(Element node, CustomElement ctor()) {
« no previous file with comments | « no previous file | pkg/mdv/lib/mdv.dart » ('j') | pkg/mdv/lib/mdv.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698