Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2225283002: Android Omnibox: Do not force LTR text direction when empty. (Closed)

Created:
4 years, 4 months ago by Matt Giuca
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Android Omnibox: Do not force LTR text direction when empty. Fixes a regression introduced in r400359: the "Search or type URL" placeholder text jumping back and forth from left and right alignment when in RTL languages. Also fixes incorrect text direction when restoring a closed tab. BUG=631422 TEST=On a phone-sized Android device, with language set to Hebrew/Arabic, in landscape, open New Tab Page and scroll page up and down. Should see the grey placeholder text in Omnibox always right-aligned, not jumping from left to right. Review-Url: https://codereview.chromium.org/2182183008 Cr-Commit-Position: refs/heads/master@{#410510} (cherry picked from commit 1d266aa00775a9e9307c7d342fb6354ba7707012) Committed: https://chromium.googlesource.com/chromium/src/+/e7f029f303598ce9e0e143859325c48d1043a21b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java View 3 chunks +22 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Matt Giuca
4 years, 4 months ago (2016-08-09 03:22:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e7f029f303598ce9e0e143859325c48d1043a21b.

Powered by Google App Engine
This is Rietveld 408576698