Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2225273002: Only add swiftshader/include to include_dirs on Windows. (Closed)

Created:
4 years, 4 months ago by hshi1
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only add swiftshader/include to include_dirs on Windows. This fixes build breakages on tot-chrome-pfq-informational bots where stale header files under third_party/swiftshader/include/EGL/ gets picked up ahead of the actual eglplatform.h header under third_party/khronos. BUG=chrome-os-partner:56035 TBR=piman@chromium.org

Patch Set 1 #

Patch Set 2 : Fix failure on win_* bots. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/gl/init/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
hshi1
PTAL. +piman (OWNERS) +marcheu, +kylechar (FYI)
4 years, 4 months ago (2016-08-09 00:37:42 UTC) #3
stevenjb
This LGTM. I would TBR it if you need an owner and they are not ...
4 years, 4 months ago (2016-08-09 01:15:14 UTC) #10
piman
lgtm
4 years, 4 months ago (2016-08-09 01:35:09 UTC) #12
hshi1
4 years, 4 months ago (2016-08-09 02:25:54 UTC) #13
Abandoning this CL because apparently there's a dupe bug where someone already
landed a fix for it before I could.

https://bugs.chromium.org/p/chromium/issues/detail?id=635702

Powered by Google App Engine
This is Rietveld 408576698