Adds config component to Machine Provider

appengine/machine_provider/main.py

 # Copyright 2015 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """Handlers for HTTP requests."""
 
 from components import utils
 
 import gae_ts_mon
 
+import config
 import handlers_cron
 import handlers_endpoints
 import handlers_frontend
 import handlers_queues
 
 
 utils.set_task_queue_module('default')

[M-A Ruel, 2016/08/09 19:22:41]

I'd prefer, while at it, to refactor this file into a proper function call:

def is_enabled_callback():
  return config.settings().enable_ts_monitoring


def main():
  utils.set_task_queue_module('default')
  c = handlers_cron.create_cron_app()
  e = handlers_endpoints.create_endpoints_app()
  f = handlers_frontend.create_frontend_app()
  q = handlers_queues.create_queues_app()
  for app in (c, e, f, q):
    gae_ts_mon.initialize(app=app, is_enabled_fn=is_enabled_callback)
  return c, e, f, q


cron_app, endpoints_app, frontend_app, queue_app = main()


or something like that, but that's optional.

[ryanmartens, 2016/08/09 21:16:31]

Agree that we should refactor this. What are your thoughts on a tuple instead?

 
 cron_app = handlers_cron.create_cron_app()
 endpoints_app = handlers_endpoints.create_endpoints_app()
 frontend_app = handlers_frontend.create_frontend_app()
 queue_app = handlers_queues.create_queues_app()
 
-gae_ts_mon.initialize(app=cron_app)
-gae_ts_mon.initialize(app=frontend_app)
-gae_ts_mon.initialize(app=queue_app)
+def is_enabled_callback():
+  return config.settings().enable_ts_monitoring
+
+gae_ts_mon.initialize(app=cron_app, is_enabled_fn=is_enabled_callback)
+gae_ts_mon.initialize(app=frontend_app, is_enabled_fn=is_enabled_callback)
+gae_ts_mon.initialize(app=queue_app, is_enabled_fn=is_enabled_callback)