Issue 2225243003: Revert "Reapply fast-URI patch."

Issue 2225243003: Revert "Reapply fast-URI patch." (Closed)

Created:
4 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
4 years, 4 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva, mit

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1314 lines, -2667 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/util/fast_uri.dart	View	1 chunk	+17 lines, -1 line	0 comments	Download
M	runtime/lib/uri_patch.dart	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/core_patch.dart	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	sdk/lib/core/uri.dart	View	39 chunks	+1284 lines, -2388 lines	0 comments	Download
M	tests/compiler/dart2js/compiler_helper.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/mirrors_used_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/data_uri_test.dart	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	tests/corelib/uri_test.dart	View	7 chunks	+4 lines, -247 lines	0 comments	Download

Total messages: 5 (2 generated)

Lasse Reichstein Nielsen

@asiva Any idea why this causes (apparent) heap corruption when running vm/cc/IsolateReload_NotEnumToEnum in debug mode?

4 years, 4 months ago (2016-08-09 10:51:35 UTC) #2

Lasse Reichstein Nielsen

Committed patchset #1 (id:1) manually as 3502fd5fd78e686683e0a14fecb28bd6f71bced2 (presubmit successful).

4 years, 4 months ago (2016-08-09 10:52:04 UTC) #4

Message was sent while issue was closed.

LGTM.