Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: net/test/ct_test_util.cc

Issue 2225223002: Certificate Transparency: Change CTVerifyResult to have a single list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing Eric's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/test/ct_test_util.cc
diff --git a/net/test/ct_test_util.cc b/net/test/ct_test_util.cc
index 3d79967f14f24e9c1220928ece2f522e18face23..590fbf7504d8910695b8e77c53c6cc2b87109649 100644
--- a/net/test/ct_test_util.cc
+++ b/net/test/ct_test_util.cc
@@ -399,15 +399,22 @@ std::string GetSCTListWithInvalidSCT() {
bool CheckForSingleVerifiedSCTInResult(const ct::CTVerifyResult& result,
const std::string& log_description) {
- return (result.verified_scts.size() == 1U) && result.invalid_scts.empty() &&
- result.unknown_logs_scts.empty() &&
- result.verified_scts[0]->log_description == log_description;
+ return (result.scts.size() == 1 &&
+ result.scts[0].status == ct::SCT_STATUS_OK &&
+ result.scts[0].sct->log_description == log_description);
}
bool CheckForSCTOrigin(const ct::CTVerifyResult& result,
ct::SignedCertificateTimestamp::Origin origin) {
- return (result.verified_scts.size() > 0) &&
- (result.verified_scts[0]->origin == origin);
+ if (result.scts.size() == 0)
eroman 2016/08/11 22:55:50 [optional] Can delete this line.
Eran Messeri 2016/08/13 21:53:26 Done.
+ return false;
+
+ for (const auto& sct_and_status : result.scts)
+ if (sct_and_status.status == SCT_STATUS_OK &&
+ sct_and_status.sct->origin == origin)
+ return true;
+
+ return false;
}
} // namespace ct
« net/cert/ct_signed_certificate_timestamp_log_param.cc ('K') | « net/ssl/ssl_info.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698