Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1738)

Unified Diff: net/ssl/ssl_info.cc

Issue 2225223002: Certificate Transparency: Change CTVerifyResult to have a single list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/ssl/ssl_info.cc
diff --git a/net/ssl/ssl_info.cc b/net/ssl/ssl_info.cc
index ce7c949a0d2ce281b50bb144e2266cda5b4c7dd7..e57272543cef4af5d05fd829cf30d962583c2939 100644
--- a/net/ssl/ssl_info.cc
+++ b/net/ssl/ssl_info.cc
@@ -77,18 +77,10 @@ void SSLInfo::SetCertError(int error) {
void SSLInfo::UpdateCertificateTransparencyInfo(
const ct::CTVerifyResult& ct_verify_result) {
- for (const auto& sct : ct_verify_result.verified_scts) {
- signed_certificate_timestamps.push_back(
- SignedCertificateTimestampAndStatus(sct, ct::SCT_STATUS_OK));
- }
- for (const auto& sct : ct_verify_result.invalid_scts) {
- signed_certificate_timestamps.push_back(
- SignedCertificateTimestampAndStatus(sct, ct::SCT_STATUS_INVALID));
- }
- for (const auto& sct : ct_verify_result.unknown_logs_scts) {
- signed_certificate_timestamps.push_back(
- SignedCertificateTimestampAndStatus(sct, ct::SCT_STATUS_LOG_UNKNOWN));
- }
+ signed_certificate_timestamps.clear();
+ signed_certificate_timestamps.insert(signed_certificate_timestamps.begin(),
+ ct_verify_result.scts.begin(),
+ ct_verify_result.scts.end());
ct_compliance_details_available = ct_verify_result.ct_policies_applied;
ct_cert_policy_compliance = ct_verify_result.cert_policy_compliance;

Powered by Google App Engine
This is Rietveld 408576698