Make GetBestPageForOnlineURL async

chrome/browser/android/offline_pages/offline_page_tab_helper.h

Index: chrome/browser/android/offline_pages/offline_page_tab_helper.h
diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper.h b/chrome/browser/android/offline_pages/offline_page_tab_helper.h
index 3a9b3e5fbab3dc963cd6916bc0fe8828c8f09a60..002cd65cfa9a67a9927da1f5815d4f774b21d512 100644
--- a/chrome/browser/android/offline_pages/offline_page_tab_helper.h
+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper.h
@@ -32,7 +32,7 @@ class OfflinePageTabHelper :
    public:
     virtual ~Delegate() {}
     virtual bool GetTabId(content::WebContents* web_contents,
-                          std::string* tab_id) const = 0;
+                          int* tab_id) const = 0;
     virtual base::Time Now() const = 0;
   };
 
@@ -94,12 +94,12 @@ class OfflinePageTabHelper :
   // redirect to that offline page, and caching metadata of that page locally.
   // RedirectResult is accumulated along the codepath to reflect the overall
   // result of redirection - and be reported to UMA at the end.
-  void GetPagesForRedirectToOffline(RedirectResult result,
-                                    const GURL& online_url);
-  void SelectBestPageForRedirectToOffline(
+  void GetBestPageForRedirectToOffline(RedirectResult result,
+                                       const GURL& online_url);
+  void GetBestPageForOnlineURLDone(

[Dmitry Titov, 2016/08/10 02:56:37]

the name doesn't match what this method does now. 
Maybe ContinueRedirectToOfflinePage?

[jianli, 2016/08/11 00:33:27]

Per discussion, changed to SelectPageForOnlineURLDone.

       RedirectResult result,
       const GURL& online_url,
-      const MultipleOfflinePageItemResult& pages);
+      const OfflinePageItem* offline_page);
   void TryRedirectToOffline(RedirectResult result,
                             const GURL& from_url,
                             const OfflinePageItem& offline_page);