Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: build/config/mac/mac_sdk.gni

Issue 2225203003: [iOS] Fix compilation of official build with Xcode 8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a TODO Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 6
7 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453. 7 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.
8 # We can drop the rtc_require_mac_10_7_deployment flag when Chromium 8 # We can drop the rtc_require_mac_10_7_deployment flag when Chromium
9 # also requires a 10.7 deployment target. 9 # also requires a 10.7 deployment target.
10 import("//build_overrides/build.gni") 10 import("//build_overrides/build.gni")
11 11
12 declare_args() { 12 declare_args() {
13 # Minimum supported version of the Mac SDK. 13 # Minimum supported version of the Mac SDK.
14 mac_sdk_min = mac_sdk_min_build_override 14 mac_sdk_min = mac_sdk_min_build_override
15 15
16 # Minimum supported version of OSX. 16 # Minimum supported version of OSX.
17 mac_deployment_target = mac_deployment_target_build_override 17 mac_deployment_target = mac_deployment_target_build_override
18 18
19 # Path to a specific version of the Mac SDK, not including a backslash at 19 # Path to a specific version of the Mac SDK, not including a backslash at
20 # the end. If empty, the path to the lowest version greater than or equal to 20 # the end. If empty, the path to the lowest version greater than or equal to
21 # mac_sdk_min is used. 21 # mac_sdk_min is used.
22 mac_sdk_path = "" 22 mac_sdk_path = ""
23 23
24 # The SDK name as accepted by xcodebuild. 24 # The SDK name as accepted by xcodebuild.
25 mac_sdk_name = "macosx" 25 mac_sdk_name = "macosx"
26 } 26 }
27 27
28 # Check that the version of macOS SDK used is the one requested when building
29 # a version of Chrome shipped to the users. Disable the check if building for
30 # iOS as the version macOS SDK used is not relevant for the tool build for the
31 # host (they are not shipped) --- this is required as Chrome on iOS is usually
32 # build with the latest version of Xcode that may not ship with the version of
33 # the macOS SDK used to build Chrome on mac.
34 # TODO(crbug.com/635745): the check for target_os should be replaced by a
35 # check that current_toolchain is default_toolchain, and the file should
36 # assert that current_os is "mac" once this file is no longer included by
37 # iOS toolchains.
38 _verify_sdk = is_chrome_branded && is_official_build && target_os != "ios"
39
28 find_sdk_args = [ "--print_sdk_path" ] 40 find_sdk_args = [ "--print_sdk_path" ]
29 if (is_chrome_branded && is_official_build) { 41 if (_verify_sdk) {
30 find_sdk_args += [ 42 find_sdk_args += [
31 "--verify", 43 "--verify",
32 mac_sdk_min, 44 mac_sdk_min,
33 "--sdk_path=" + mac_sdk_path, 45 "--sdk_path=" + mac_sdk_path,
34 ] 46 ]
35 } else { 47 } else {
36 find_sdk_args += [ mac_sdk_min ] 48 find_sdk_args += [ mac_sdk_min ]
37 } 49 }
38 50
39 # The tool will print the SDK path on the first line, and the version on the 51 # The tool will print the SDK path on the first line, and the version on the
(...skipping 29 matching lines...) Expand all
69 " either upgrade Xcode to the latest version or install the Mac O S X") 81 " either upgrade Xcode to the latest version or install the Mac O S X")
70 print( 82 print(
71 " $mac_sdk_min_build_override SDK. For more information, see http s://crbug.com/620127.") 83 " $mac_sdk_min_build_override SDK. For more information, see http s://crbug.com/620127.")
72 print() 84 print()
73 print(" Current SDK Version: $mac_sdk_version") 85 print(" Current SDK Version: $mac_sdk_version")
74 print(" Current Xcode Version: $xcode_version ($xcode_build)") 86 print(" Current Xcode Version: $xcode_version ($xcode_build)")
75 print( 87 print(
76 "************************************************************************* *******") 88 "************************************************************************* *******")
77 assert(false, "SDK is incompatible with Xcode") 89 assert(false, "SDK is incompatible with Xcode")
78 } 90 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698