Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: third_party/WebKit/Source/wtf/text/AtomicString.h

Issue 2225173002: Use StringView for String::find. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing null check. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/text/StringImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/text/AtomicString.h
diff --git a/third_party/WebKit/Source/wtf/text/AtomicString.h b/third_party/WebKit/Source/wtf/text/AtomicString.h
index ed2a0cef9e7116ab5e5201eed21115800536b53e..55b612bc9a932e561e9c2cb0215064a1230c74d4 100644
--- a/third_party/WebKit/Source/wtf/text/AtomicString.h
+++ b/third_party/WebKit/Source/wtf/text/AtomicString.h
@@ -79,13 +79,18 @@ public:
bool contains(const String& s, TextCaseSensitivity caseSensitivity = TextCaseSensitive) const
{ return m_string.contains(s, caseSensitivity); }
- size_t find(UChar c, size_t start = 0) const { return m_string.find(c, start); }
+ // Find characters.
+ size_t find(UChar c, unsigned start = 0) const
+ { return m_string.find(c, start); }
+ size_t find(LChar c, unsigned start = 0) const
+ { return m_string.find(c, start); }
+ size_t find(char c, unsigned start = 0) const { return find(static_cast<LChar>(c), start); }
size_t find(CharacterMatchFunctionPtr matchFunction, unsigned start = 0) const
{ return m_string.find(matchFunction, start); }
- size_t find(const LChar* s, size_t start = 0, TextCaseSensitivity caseSensitivity = TextCaseSensitive) const
- { return m_string.find(s, start, caseSensitivity); }
- size_t find(const String& s, size_t start = 0, TextCaseSensitivity caseSensitivity = TextCaseSensitive) const
- { return m_string.find(s, start, caseSensitivity); }
+
+ // Find substrings.
+ size_t find(const StringView& value, unsigned start = 0, TextCaseSensitivity caseSensitivity = TextCaseSensitive) const
+ { return m_string.find(value, start, caseSensitivity); }
bool startsWith(const StringView& prefix, TextCaseSensitivity caseSensitivity = TextCaseSensitive) const
{ return m_string.startsWith(prefix, caseSensitivity); }
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/text/StringImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698