Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2225163002: Rework linker tests to use SummaryDataStore. (Closed)

Created:
4 years, 4 months ago by Paul Berry
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rework linker tests to use SummaryDataStore. Also add a test to make sure that things work properly when one summary has a dependency on another. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/281322870ec9075e91b3548810fc20a702f2c049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -48 lines) Patch
M pkg/analyzer/test/src/summary/linker_test.dart View 13 chunks +36 lines, -12 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_test.dart View 7 chunks +31 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 4 months ago (2016-08-08 20:45:57 UTC) #2
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-08 20:53:14 UTC) #3
Paul Berry
4 years, 4 months ago (2016-08-08 20:58:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
281322870ec9075e91b3548810fc20a702f2c049 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698