Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2225113002: Reland: Move PVer4 related code from util.* to v4_protocol_manager_util.* (Closed)

Created:
4 years, 4 months ago by vakh (use Gerrit instead)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, grt+watch_chromium.org, palmer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Move PVer4 related code from util.* to v4_protocol_manager_util.* Original CL: https://codereview.chromium.org/2218723002/ Revert CL: https://codereview.chromium.org/2229533002/ Reason for revert: # Static initializers in /b/c/b/mac_ng/src/out/Release/Chromium Framework.framework/Chromium Framework: # HINT: To get this list, run tools/mac/show_mod_init_func.py # HINT: diff against the log from the last run to see what changed /b/c/b/mac_ng/src/out/Release/Chromium Framework.unstripped 0x00000000013489f0 @ _GLOBAL__sub_I_v4_store.cc (in Chromium Framework.unstripped) (v4_store.cc:0) 0x000000000168c3f0 @ _GLOBAL__sub_I_safe_browsing_service.cc (in Chromium Framework.unstripped) (safe_browsing_service.cc:0) 0x00000000016bbc30 @ _GLOBAL__sub_I_local_database_manager.cc (in Chromium Framework.unstripped) (local_database_manager.cc:0) 0x00000000016e6300 @ _GLOBAL__sub_I_services_delegate_impl.cc (in Chromium Framework.unstripped) (services_delegate_impl.cc:0) 0x000000000391ed70 @ _GLOBAL__sub_I_database_manager.cc (in Chromium Framework.unstripped) (database_manager.cc:0) 0x000000000391fd00 @ _GLOBAL__sub_I_util.cc (in Chromium Framework.unstripped) (util.cc:0) 0x0000000003934180 @ _GLOBAL__sub_I_v4_get_hash_protocol_manager.cc (in Chromium Framework.unstripped) (v4_get_hash_protocol_manager.cc:0) 0x0000000003936ef0 @ _GLOBAL__sub_I_v4_local_database_manager.cc (in Chromium Framework.unstripped) (v4_local_database_manager.cc:0) 0x0000000003938990 @ _GLOBAL__sub_I_v4_database.cc (in Chromium Framework.unstripped) (v4_database.cc:0) 0x000000000393a580 @ _GLOBAL__sub_I_v4_update_protocol_manager.cc (in Chromium Framework.unstripped) (v4_update_protocol_manager.cc:0) Fix: Define methods to return UpdateListIdentifier instead of static instances BUG=543161 Committed: https://crrev.com/a1910e0d538d4ec2aaaa60793d01d02365ed3c6c Cr-Commit-Position: refs/heads/master@{#410476}

Patch Set 1 #

Patch Set 2 : Define methods to return UpdateListIdentifier instead of static instances #

Total comments: 2

Patch Set 3 : Minor: Address nparker@'s comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+508 lines, -582 lines) Patch
M chrome/browser/safe_browsing/local_database_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/safe_browsing_db/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_browsing_db/util.h View 2 chunks +0 lines, -19 lines 0 comments Download
M components/safe_browsing_db/util.cc View 5 chunks +6 lines, -252 lines 0 comments Download
M components/safe_browsing_db/util_unittest.cc View 1 chunk +0 lines, -267 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 1 2 3 chunks +3 lines, -21 lines 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util.h View 1 2 6 chunks +62 lines, -11 lines 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util.cc View 1 2 3 chunks +305 lines, -0 lines 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util_unittest.cc View 5 chunks +127 lines, -4 lines 0 comments Download
M components/safe_browsing_db/v4_store.h View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
vakh (use Gerrit instead)
Define methods to return UpdateListIdentifier instead of static instances
4 years, 4 months ago (2016-08-08 19:09:20 UTC) #3
Nathan Parker
lgtm with one fix required, and one nit. https://codereview.chromium.org/2225113002/diff/20001/components/safe_browsing_db/v4_local_database_manager.cc File components/safe_browsing_db/v4_local_database_manager.cc (right): https://codereview.chromium.org/2225113002/diff/20001/components/safe_browsing_db/v4_local_database_manager.cc#newcode25 components/safe_browsing_db/v4_local_database_manager.cc:25: {GetUrlMalwareId(), ...
4 years, 4 months ago (2016-08-08 20:40:49 UTC) #11
vakh (use Gerrit instead)
Minor: Address nparker@'s comments
4 years, 4 months ago (2016-08-08 21:01:15 UTC) #12
vakh (use Gerrit instead)
On 2016/08/08 20:40:49, Nathan Parker wrote: > lgtm > > with one fix required, and ...
4 years, 4 months ago (2016-08-08 21:02:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225113002/40001
4 years, 4 months ago (2016-08-08 21:02:13 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-08 22:23:04 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 22:25:23 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a1910e0d538d4ec2aaaa60793d01d02365ed3c6c
Cr-Commit-Position: refs/heads/master@{#410476}

Powered by Google App Engine
This is Rietveld 408576698