mash: Add WmShell::SetDisplayWorkAreaInsets for ShelfLayoutManager.

mash: Add WmShell::SetDisplayWorkAreaInsets for ShelfLayoutManager.

Add WmShell::SetDisplayWorkAreaInsets helper.
(call ash::Shell in WmShellAura; notimpl in WmShellMus)
Update ShelfLayoutManager; remove unnecessary test call.
Remove ShelfLayoutManager::root_window_ member.

BUG=615155
TEST=Automated; no shelf/work-area layout regressions.
R=jamescook@chromium.org

Committed: https://crrev.com/ad28b255b026ddb41fab655e34d4b22d4e50fea2
Cr-Commit-Position: refs/heads/master@{#410548}

[msw, 2016-08-08 22:28:05]

Description was changed from

==========
mash: Add WmShell::SetDisplayWorkAreaInsets for ShelfLayoutManager.

BUG=615155
==========

to

==========
mash: Add WmShell::SetDisplayWorkAreaInsets for ShelfLayoutManager.

Add WmShell::SetDisplayWorkAreaInsets helper.
(call ash::Shell in WmShellAura; notimpl in WmShellMus)
Update ShelfLayoutManager; remove unnecessary test call.
Remove ShelfLayoutManager::root_window_ member.

BUG=615155
TEST=Automated; no shelf/work-area layout regressions.
R=jamescook@chromium.org
==========

[msw, 2016-08-08 22:28:06]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-08-08 22:28:18]

Hey James, please take a look; thanks!

[msw, 2016-08-08 22:28:32]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 22:29:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-08-08 22:32:12]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 22:33:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 23:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:06:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-08-08 23:40:05]

LGTM.

https://codereview.chromium.org/2225083003/diff/20001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2225083003/diff/20001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:192: // Sets the work area insets of the display with
|window|, notifies observers.
super nit: "display containing |window|" maybe?

https://codereview.chromium.org/2225083003/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.h (left):

https://codereview.chromium.org/2225083003/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.h:307: aura::Window* root_window_;
Nice that you could get rid of this.

https://codereview.chromium.org/2225083003/diff/20001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2225083003/diff/20001/ash/shell.h#newcode219
ash/shell.h:219: // Sets the work area insets of the display with |window|,
notifies observers.
ditto

[msw, 2016-08-08 23:58:40]

https://codereview.chromium.org/2225083003/diff/20001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2225083003/diff/20001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:192: // Sets the work area insets of the display with
|window|, notifies observers.
On 2016/08/08 23:40:04, James Cook wrote:
> super nit: "display containing |window|" maybe?

Done.

https://codereview.chromium.org/2225083003/diff/20001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.h (left):

https://codereview.chromium.org/2225083003/diff/20001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.h:307: aura::Window* root_window_;
On 2016/08/08 23:40:04, James Cook wrote:
> Nice that you could get rid of this.

Acknowledged.

https://codereview.chromium.org/2225083003/diff/20001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2225083003/diff/20001/ash/shell.h#newcode219
ash/shell.h:219: // Sets the work area insets of the display with |window|,
notifies observers.
On 2016/08/08 23:40:04, James Cook wrote:
> ditto

Done.

[msw, 2016-08-08 23:58:45]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-08 23:58:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2225083003/#ps40001
(title: "Address nits; fix bad argument.")

[commit-bot: I haz the power, 2016-08-08 23:59:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 02:42:22]

Description was changed from

==========
mash: Add WmShell::SetDisplayWorkAreaInsets for ShelfLayoutManager.

Add WmShell::SetDisplayWorkAreaInsets helper.
(call ash::Shell in WmShellAura; notimpl in WmShellMus)
Update ShelfLayoutManager; remove unnecessary test call.
Remove ShelfLayoutManager::root_window_ member.

BUG=615155
TEST=Automated; no shelf/work-area layout regressions.
R=jamescook@chromium.org
==========

to

==========
mash: Add WmShell::SetDisplayWorkAreaInsets for ShelfLayoutManager.

Add WmShell::SetDisplayWorkAreaInsets helper.
(call ash::Shell in WmShellAura; notimpl in WmShellMus)
Update ShelfLayoutManager; remove unnecessary test call.
Remove ShelfLayoutManager::root_window_ member.

BUG=615155
TEST=Automated; no shelf/work-area layout regressions.
R=jamescook@chromium.org
==========

[commit-bot: I haz the power, 2016-08-09 02:42:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-09 02:45:03]

Description was changed from

==========
mash: Add WmShell::SetDisplayWorkAreaInsets for ShelfLayoutManager.

Add WmShell::SetDisplayWorkAreaInsets helper.
(call ash::Shell in WmShellAura; notimpl in WmShellMus)
Update ShelfLayoutManager; remove unnecessary test call.
Remove ShelfLayoutManager::root_window_ member.

BUG=615155
TEST=Automated; no shelf/work-area layout regressions.
R=jamescook@chromium.org
==========

to

==========
mash: Add WmShell::SetDisplayWorkAreaInsets for ShelfLayoutManager.

Add WmShell::SetDisplayWorkAreaInsets helper.
(call ash::Shell in WmShellAura; notimpl in WmShellMus)
Update ShelfLayoutManager; remove unnecessary test call.
Remove ShelfLayoutManager::root_window_ member.

BUG=615155
TEST=Automated; no shelf/work-area layout regressions.
R=jamescook@chromium.org

Committed: https://crrev.com/ad28b255b026ddb41fab655e34d4b22d4e50fea2
Cr-Commit-Position: refs/heads/master@{#410548}
==========

[commit-bot: I haz the power, 2016-08-09 02:45:05]

Patchset 3 (id:??) landed as
https://crrev.com/ad28b255b026ddb41fab655e34d4b22d4e50fea2
Cr-Commit-Position: refs/heads/master@{#410548}