[Chrome OS] Change layout of the launcher.

[Chrome OS] Change layout of the launcher.

- Add an additional row of "recent apps" to the launcher.
- Add recently installed app to "recent apps" for quick discovery.

BUG=633365
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3f4de06f8aea12e28828adbdcd56307b228c0e2a
Cr-Commit-Position: refs/heads/master@{#412072}

[xdai1, 2016-08-08 16:49:26]

xdai@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xdai1, 2016-08-08 16:49:26]

xiyuan@, could you help review this CL please? Thanks!

[xiyuan, 2016-08-08 18:02:15]

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc (right):

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc:626: if
(GetInstallTime(app_id).is_null()) {
nit: Document that |install_time| is the first time we saw the app, not the real
install time.

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/search/app_result.cc (right):

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/search/app_result.cc:29: base::TimeDelta delta =
current_time - old_time;
nit: move this after the "if" below since you are here.

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/search/app_result.cc:30: // |current_time| can be
before |last_launched| in weird cases such as users
nit: update this comment, |last_launched| -> |old_time|

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/search/app_search_provider.cc (right):

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/search/app_search_provider.cc:318: if
(app->install_time().is_null()) {
nit: prefer to choose a time and get rid of one nested "if"

i.e.
  const base::Time time = app->last_launch_time().is_null() ?
      app->install_time() : app->last_launch_time();
  if (time.is_null()){
    ...
  } else {
    ...
  }

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/search/mixer.cc
File ui/app_list/search/mixer.cc (right):

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/search/mixer.cc...
ui/app_list/search/mixer.cc:22: const size_t kMinResults = 9;
Would this change the search result UI? That is, the mixer generates 6 results
on search but generates 9 now. The result list view only shows the first 6. This
might cause low weight results never get shown.

We probably needs to pass this number from outside, e.g. from SearchController,
as an arg to MixAndPublish, and use 6 for regular search and 9 when the search
is for recommendations (query is empty).

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/views/start_pag...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/views/start_pag...
ui/app_list/views/start_page_view.cc:51: const int kNumStartPageTiles = 9;
nit: do we have to replace size_t with int?

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/views/start_pag...
ui/app_list/views/start_page_view.cc:187: display_results.size() > 0) {
Think we need to update the gird when display_results.size() !=
search_result_tile_views_.size().

And handle the size constraint in the branch, i.e. in line 193
  CreateAppsGrid(std::min(kNumStartPageTiles, display_results.size()));

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/views/start_pag...
ui/app_list/views/start_page_view.cc:191: search_result_tile_views_.clear();
Would this leak? That is, RemoveChildView() does not delete the child view and
just removes it from view hierarchy. And when the reference in vector is removed
here. Who is going to release the actual view? We probably should do a "delete
search_result_tile_views_[i]" in the loop.

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/views/start_pag...
ui/app_list/views/start_page_view.cc:238: views::GridLayout*
tiles_layout_manager = new views::GridLayout(this);
nit: DCHECK(search_result_tile_views_.empty()) to ensure it is empty when
calling into this function.

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/views/start_pag...
ui/app_list/views/start_page_view.cc:266:
all_apps_button_->SetParentBackgroundColor(kLabelBackgroundColor);
nit: hover style in line 264 and this background color can stay in ctor since we
don't need to set them every time when creating the grid.

[xdai1, 2016-08-08 21:25:38]

xiyuan@, I've addressed your comments. Please take another look, thanks!

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc (right):

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc:626: if
(GetInstallTime(app_id).is_null()) {
On 2016/08/08 18:02:14, xiyuan wrote:
> nit: Document that |install_time| is the first time we saw the app, not the
real
> install time.

Done.

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/search/app_result.cc (right):

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/search/app_result.cc:29: base::TimeDelta delta =
current_time - old_time;
On 2016/08/08 18:02:15, xiyuan wrote:
> nit: move this after the "if" below since you are here.

Done.

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/search/app_result.cc:30: // |current_time| can be
before |last_launched| in weird cases such as users
On 2016/08/08 18:02:15, xiyuan wrote:
> nit: update this comment, |last_launched| -> |old_time|

Done.

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/search/app_search_provider.cc (right):

https://codereview.chromium.org/2225073002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/search/app_search_provider.cc:318: if
(app->install_time().is_null()) {
On 2016/08/08 18:02:15, xiyuan wrote:
> nit: prefer to choose a time and get rid of one nested "if"
> 
> i.e.
>   const base::Time time = app->last_launch_time().is_null() ?
>       app->install_time() : app->last_launch_time();
>   if (time.is_null()){
>     ...
>   } else {
>     ...
>   }

Done.

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/search/mixer.cc
File ui/app_list/search/mixer.cc (right):

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/search/mixer.cc...
ui/app_list/search/mixer.cc:22: const size_t kMinResults = 9;
On 2016/08/08 18:02:15, xiyuan wrote:
> Would this change the search result UI? That is, the mixer generates 6 results
> on search but generates 9 now. The result list view only shows the first 6.
This
> might cause low weight results never get shown.
> 
> We probably needs to pass this number from outside, e.g. from
SearchController,
> as an arg to MixAndPublish, and use 6 for regular search and 9 when the search
> is for recommendations (query is empty).

No it doesn't change the search result UI. The number of the search results is
always 8. The reason I changed kMinResults here is because if I don't change it,
the size |display_results| in StartPageView::StartPageTilesContainer::Update()
is always 8, but we need 9...

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/views/start_pag...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/views/start_pag...
ui/app_list/views/start_page_view.cc:51: const int kNumStartPageTiles = 9;
On 2016/08/08 18:02:15, xiyuan wrote:
> nit: do we have to replace size_t with int?

Reverted it back. Not necessarily... I just thought it might be good to be
consistent with other variables.

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/views/start_pag...
ui/app_list/views/start_page_view.cc:187: display_results.size() > 0) {
On 2016/08/08 18:02:15, xiyuan wrote:
> Think we need to update the gird when display_results.size() !=
> search_result_tile_views_.size().
> 
> And handle the size constraint in the branch, i.e. in line 193
>   CreateAppsGrid(std::min(kNumStartPageTiles, display_results.size()));

Done.

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/views/start_pag...
ui/app_list/views/start_page_view.cc:191: search_result_tile_views_.clear();
On 2016/08/08 18:02:15, xiyuan wrote:
> Would this leak? That is, RemoveChildView() does not delete the child view and
> just removes it from view hierarchy. And when the reference in vector is
removed
> here. Who is going to release the actual view? We probably should do a "delete
> search_result_tile_views_[i]" in the loop.

You're right. I think we should manually delete the child views.

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/views/start_pag...
ui/app_list/views/start_page_view.cc:238: views::GridLayout*
tiles_layout_manager = new views::GridLayout(this);
On 2016/08/08 18:02:15, xiyuan wrote:
> nit: DCHECK(search_result_tile_views_.empty()) to ensure it is empty when
> calling into this function.

Done.

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/views/start_pag...
ui/app_list/views/start_page_view.cc:266:
all_apps_button_->SetParentBackgroundColor(kLabelBackgroundColor);
On 2016/08/08 18:02:15, xiyuan wrote:
> nit: hover style in line 264 and this background color can stay in ctor since
we
> don't need to set them every time when creating the grid.

Done.

[xdai1, 2016-08-08 21:30:08]

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/search/mixer.cc
File ui/app_list/search/mixer.cc (right):

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/search/mixer.cc...
ui/app_list/search/mixer.cc:22: const size_t kMinResults = 9;
On 2016/08/08 18:02:15, xiyuan wrote:
> Would this change the search result UI? That is, the mixer generates 6 results
> on search but generates 9 now. The result list view only shows the first 6.
This
> might cause low weight results never get shown.
> 
> We probably needs to pass this number from outside, e.g. from
SearchController,
> as an arg to MixAndPublish, and use 6 for regular search and 9 when the search
> is for recommendations (query is empty).

kNumSearchResultTiles
(https://cs.chromium.org/chromium/src/ui/app_list/views/search_result_tile_ite...
) is used to control the number of the search results.

[xiyuan, 2016-08-08 21:41:01]

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/search/mixer.cc
File ui/app_list/search/mixer.cc (right):

https://codereview.chromium.org/2225073002/diff/1/ui/app_list/search/mixer.cc...
ui/app_list/search/mixer.cc:22: const size_t kMinResults = 9;
On 2016/08/08 21:30:08, xdai1 wrote:
> On 2016/08/08 18:02:15, xiyuan wrote:
> > Would this change the search result UI? That is, the mixer generates 6
results
> > on search but generates 9 now. The result list view only shows the first 6.
> This
> > might cause low weight results never get shown.
> > 
> > We probably needs to pass this number from outside, e.g. from
> SearchController,
> > as an arg to MixAndPublish, and use 6 for regular search and 9 when the
search
> > is for recommendations (query is empty).
> 
> kNumSearchResultTiles
>
(https://cs.chromium.org/chromium/src/ui/app_list/views/search_result_tile_ite...
> ) is used to control the number of the search results.

The mixer is applying weight and sort the results based on scores. Certain
provider (such as Webstore result provider) has low priority so that its results
are always at the end of the list. Creating 9 results here while we only show 6
results [1] would cause the results from such provider never show up. 

[1]:
https://cs.chromium.org/chromium/src/ui/app_list/views/search_result_list_vie...

https://codereview.chromium.org/2225073002/diff/20001/ui/app_list/views/start...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/2225073002/diff/20001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:189: display_results.size() > 0) {
What happens if display_results.size() == 0? Shouldn't we remove all tiles and
only show the app_apps_button_ ?

[xdai1, 2016-08-09 17:34:21]

xiyuan@, I've addressed your comments. Please take another look at this CL,
thanks!

[xiyuan, 2016-08-09 17:49:09]

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/search/mixe...
File ui/app_list/search/mixer.cc (right):

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/search/mixe...
ui/app_list/search/mixer.cc:146: size_t num_max_results = is_empty_query ?
kNumStartPageTiles : kMinResults;
Can we move this logic out of Mixer and pass this as an arg? Mixer does not need
to know the difference of empty query or not.

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/search_cont...
File ui/app_list/search_controller.cc (right):

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/search_cont...
ui/app_list/search_controller.cc:60: OnResultsChanged(query.empty());
We should remember empty query in a member var instead of passing it to
OnResultsChanged. Also prefer to call it query_for_recommendation_ instead of
is_empty_query_ and do it after line 58 and before this line.

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/search_cont...
ui/app_list/search_controller.cc:122: &SearchController::OnResultsChanged,
base::Unretained(this), true));
As aforementioned, let's remember the query_for_recommendation_ and use that in
OnResultsChanged instead of binding true here.

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:53: const int kTilesHorizontalMarginLeft =
145;
nit: const int -> constexpr int here and all other consts

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:190:
RemoveChildView(search_result_tile_views_[i]);
Not necessary. Deleting a view would remove it from its parent [1].

[1] https://cs.chromium.org/chromium/src/ui/views/view.cc?rcl=0&l=127

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:246: for (int col = 0; col <
kNumStartPageTilesCols; col++) {
nit: col++ -> ++col

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:254: for (; i < apps_num; i++) {
nit: i++ -> ++i

[xdai1, 2016-08-09 20:14:18]

xiyuan@, I've addressed your comments. Please take another look, thanks!

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/search/mixe...
File ui/app_list/search/mixer.cc (right):

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/search/mixe...
ui/app_list/search/mixer.cc:146: size_t num_max_results = is_empty_query ?
kNumStartPageTiles : kMinResults;
On 2016/08/09 17:49:09, xiyuan wrote:
> Can we move this logic out of Mixer and pass this as an arg? Mixer does not
need
> to know the difference of empty query or not.

Done.

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/search_cont...
File ui/app_list/search_controller.cc (right):

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/search_cont...
ui/app_list/search_controller.cc:60: OnResultsChanged(query.empty());
On 2016/08/09 17:49:09, xiyuan wrote:
> We should remember empty query in a member var instead of passing it to
> OnResultsChanged. Also prefer to call it query_for_recommendation_ instead of
> is_empty_query_ and do it after line 58 and before this line.

Done.

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/search_cont...
ui/app_list/search_controller.cc:122: &SearchController::OnResultsChanged,
base::Unretained(this), true));
On 2016/08/09 17:49:09, xiyuan wrote:
> As aforementioned, let's remember the query_for_recommendation_ and use that
in
> OnResultsChanged instead of binding true here.

Done.

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:53: const int kTilesHorizontalMarginLeft =
145;
On 2016/08/09 17:49:09, xiyuan wrote:
> nit: const int -> constexpr int here and all other consts

Done.

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:190:
RemoveChildView(search_result_tile_views_[i]);
On 2016/08/09 17:49:09, xiyuan wrote:
> Not necessary. Deleting a view would remove it from its parent [1].
> 
> [1] https://cs.chromium.org/chromium/src/ui/views/view.cc?rcl=0&l=127

Done.

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:246: for (int col = 0; col <
kNumStartPageTilesCols; col++) {
On 2016/08/09 17:49:09, xiyuan wrote:
> nit: col++ -> ++col

I think they're same?

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:254: for (; i < apps_num; i++) {
On 2016/08/09 17:49:09, xiyuan wrote:
> nit: i++ -> ++i

same?

[xiyuan, 2016-08-09 20:22:13]

lgtm

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:246: for (int col = 0; col <
kNumStartPageTilesCols; col++) {
On 2016/08/09 20:14:17, xdai1 wrote:
> On 2016/08/09 17:49:09, xiyuan wrote:
> > nit: col++ -> ++col
> 
> I think they're same?

Haha... This used to be an interview question asked by Google. :)

It maybe true that modern compiler would optimize and makes the two forms to
have the same efficiency. But google prefers ++i when you can, see C++ style
guide:

https://google.github.io/styleguide/cppguide.html#Preincrement_and_Predecrement

https://codereview.chromium.org/2225073002/diff/60001/ui/app_list/search_cont...
File ui/app_list/search_controller.cc (right):

https://codereview.chromium.org/2225073002/diff/60001/ui/app_list/search_cont...
ui/app_list/search_controller.cc:36: query_for_recommendation_(false),
nit: init |query_for_recommendation_| and |is_voice_query_| in header ?

[xdai1, 2016-08-09 20:33:06]

xiyuan@, thanks for the review!

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/2225073002/diff/40001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:246: for (int col = 0; col <
kNumStartPageTilesCols; col++) {
On 2016/08/09 20:22:12, xiyuan wrote:
> On 2016/08/09 20:14:17, xdai1 wrote:
> > On 2016/08/09 17:49:09, xiyuan wrote:
> > > nit: col++ -> ++col
> > 
> > I think they're same?
> 
> Haha... This used to be an interview question asked by Google. :)
> 
> It maybe true that modern compiler would optimize and makes the two forms to
> have the same efficiency. But google prefers ++i when you can, see C++ style
> guide:
> 
>
https://google.github.io/styleguide/cppguide.html#Preincrement_and_Predecrement

I see. Thanks!

https://codereview.chromium.org/2225073002/diff/60001/ui/app_list/search_cont...
File ui/app_list/search_controller.cc (right):

https://codereview.chromium.org/2225073002/diff/60001/ui/app_list/search_cont...
ui/app_list/search_controller.cc:36: query_for_recommendation_(false),
On 2016/08/09 20:22:13, xiyuan wrote:
> nit: init |query_for_recommendation_| and |is_voice_query_| in header ?

Done.

[xdai1, 2016-08-09 20:33:17]

The CQ bit was checked by xdai@chromium.org

[xdai1, 2016-08-09 20:33:17]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2225073002/#ps80001
(title: "Initialize the variable in the header.")

[commit-bot: I haz the power, 2016-08-09 20:34:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-08-09 20:34:33]

https://codereview.chromium.org/2225073002/diff/60001/ui/app_list/search_cont...
File ui/app_list/search_controller.cc (right):

https://codereview.chromium.org/2225073002/diff/60001/ui/app_list/search_cont...
ui/app_list/search_controller.cc:36: query_for_recommendation_(false),
On 2016/08/09 20:33:06, xdai1 wrote:
> On 2016/08/09 20:22:13, xiyuan wrote:
> > nit: init |query_for_recommendation_| and |is_voice_query_| in header ?
> 
> Done.

You might forget to include latest header file in PS5.

[xdai1, 2016-08-09 20:41:21]

On 2016/08/09 20:34:33, xiyuan wrote:
>
https://codereview.chromium.org/2225073002/diff/60001/ui/app_list/search_cont...
> File ui/app_list/search_controller.cc (right):
> 
>
https://codereview.chromium.org/2225073002/diff/60001/ui/app_list/search_cont...
> ui/app_list/search_controller.cc:36: query_for_recommendation_(false),
> On 2016/08/09 20:33:06, xdai1 wrote:
> > On 2016/08/09 20:22:13, xiyuan wrote:
> > > nit: init |query_for_recommendation_| and |is_voice_query_| in header ?
> > 
> > Done.
> 
> You might forget to include latest header file in PS5.

....Sorry! Not sure why it happened... Is there any way to cancel the commit?

[xiyuan, 2016-08-09 20:57:39]

On 2016/08/09 20:41:21, xdai1 wrote:
> ....Sorry! Not sure why it happened... Is there any way to cancel the commit?

Uncheck the CQ box ?

[xdai1, 2016-08-09 21:00:58]

On 2016/08/09 20:57:39, xiyuan wrote:
> On 2016/08/09 20:41:21, xdai1 wrote:
> > ....Sorry! Not sure why it happened... Is there any way to cancel the
commit?
> 
> Uncheck the CQ box ?

No worries. The PS5 failed the unittest because MixAndPublish() function now
takes 3 arguments. I'll fix both of them in the new patch.

[xdai1, 2016-08-10 00:45:15]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 00:45:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 01:24:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 01:24:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xdai1, 2016-08-10 23:47:15]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 23:48:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 23:52:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 23:52:15]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[xdai1, 2016-08-11 00:29:52]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 00:30:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 01:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 01:35:01]

Dry run: This issue passed the CQ dry run.

[xdai1, 2016-08-15 20:28:26]

Description was changed from

==========
[Chrome OS] Change layout of the launcher.

- Add an additional row of "recent apps" to the launcher.
- Add recently installed app to "recent apps" for quick discovery.

BUG=633365
==========

to

==========
[Chrome OS] Change layout of the launcher.

- Add an additional row of "recent apps" to the launcher.
- Add recently installed app to "recent apps" for quick discovery.

BUG=633365
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[xdai1, 2016-08-15 20:29:35]

The CQ bit was checked by xdai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 20:30:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 22:12:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 22:12:34]

Dry run: This issue passed the CQ dry run.

[xdai1, 2016-08-15 22:19:13]

The CQ bit was checked by xdai@chromium.org

[xdai1, 2016-08-15 22:19:14]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2225073002/#ps180001
(title: "Rebase & scale the Google Doodle image when it's too large.")

[commit-bot: I haz the power, 2016-08-15 22:19:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 22:24:00]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-08-15 22:27:40]

Description was changed from

==========
[Chrome OS] Change layout of the launcher.

- Add an additional row of "recent apps" to the launcher.
- Add recently installed app to "recent apps" for quick discovery.

BUG=633365
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[Chrome OS] Change layout of the launcher.

- Add an additional row of "recent apps" to the launcher.
- Add recently installed app to "recent apps" for quick discovery.

BUG=633365
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3f4de06f8aea12e28828adbdcd56307b228c0e2a
Cr-Commit-Position: refs/heads/master@{#412072}
==========

[commit-bot: I haz the power, 2016-08-15 22:27:41]

Patchset 10 (id:??) landed as
https://crrev.com/3f4de06f8aea12e28828adbdcd56307b228c0e2a
Cr-Commit-Position: refs/heads/master@{#412072}