Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Issue 2225053002: Fix tests to behave properly with ISNs/DSNs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/test_render_frame_host.cc » ('j') | content/test/test_render_frame_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl_browsertest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_browsertest.cc b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
index 4594946033b61ab03c8ae56ce52954927d83dd72..9ed78c9ea5e021835854ed770fd4f6cf3165a28d 100644
--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
@@ -484,10 +484,8 @@ bool NavigateToURLAndReplace(Shell* shell, const GURL& url) {
WebContents* web_contents = shell->web_contents();
WaitForLoadStop(web_contents);
TestNavigationObserver same_tab_observer(web_contents, 1);
- NavigationController::LoadURLParams params(url);
- params.should_replace_current_entry = true;
- web_contents->GetController().LoadURLWithParams(params);
- web_contents->Focus();
+ EXPECT_TRUE(
+ ExecuteScript(shell, "window.location.replace('" + url.spec() + "');"));
same_tab_observer.Wait();
if (!IsLastCommittedEntryOfPageType(web_contents, PAGE_TYPE_NORMAL))
return false;
« no previous file with comments | « no previous file | content/test/test_render_frame_host.cc » ('j') | content/test/test_render_frame_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698