Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2225043002: Supress failing WebGL2 fbomultisample tests on Linux Intel. (Closed)

Created:
4 years, 4 months ago by Geoff Lang
Modified:
4 years, 4 months ago
Reviewers:
yunchao, Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Supress failing WebGL2 fbomultisample tests on Linux Intel. TBR=zmo@chromium.org NOTRY=true BUG=635528 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/44a074dc34d20e018d3f877273f7a7419391f78e Committed: https://crrev.com/9c852756300d2cfccbf0438c35df8d584fa718de Cr-Original-Commit-Position: refs/heads/master@{#410350} Cr-Commit-Position: refs/heads/master@{#410353}

Patch Set 1 #

Patch Set 2 : fix vendor typo #

Patch Set 3 : fix vendor typo #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 21 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225043002/1
4 years, 4 months ago (2016-08-08 14:39:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 14:42:23 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/44a074dc34d20e018d3f877273f7a7419391f78e Cr-Commit-Position: refs/heads/master@{#410350}
4 years, 4 months ago (2016-08-08 14:44:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225043002/40001
4 years, 4 months ago (2016-08-08 14:52:09 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-08 14:55:42 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/9c852756300d2cfccbf0438c35df8d584fa718de Cr-Commit-Position: refs/heads/master@{#410353}
4 years, 4 months ago (2016-08-08 14:58:25 UTC) #17
yunchao
Hi, @geofflang, could you have a look at my comments inline? https://codereview.chromium.org/2225043002/diff/40001/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): ...
4 years, 4 months ago (2016-08-08 15:08:48 UTC) #19
Geoff Lang
On 2016/08/08 15:08:48, yunchao wrote: > Hi, @geofflang, could you have a look at my ...
4 years, 4 months ago (2016-08-08 15:30:33 UTC) #20
jchen10
4 years, 4 months ago (2016-08-09 02:05:48 UTC) #21
Message was sent while issue was closed. 
On 2016/08/08 15:30:33, Geoff Lang wrote:
> On 2016/08/08 15:08:48, yunchao wrote:
> > Hi, @geofflang, could you have a look at my comments inline?
> > 
> >
>
https://codereview.chromium.org/2225043002/diff/40001/content/test/gpu/gpu_te...
> > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right):
> > 
> >
>
https://codereview.chromium.org/2225043002/diff/40001/content/test/gpu/gpu_te...
> > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:586: ['linux',
> > 'intel', 'opengl'], bug=635528)
> > This is a mesa bug for multisampled float point renderbuffer. 
> > I wonder that do you only found that fbomultisample.8_samples.html failed on
> > Linux intel driver? 
> > I thought that fbomultisample.2_samples.html and
fbomultisample.4_samples.html
> > also fail.
> 
> Going through the recent failures on the bot
>
(https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28N...),
> it looks like only these specific tests are failing.  I'm not sure why the
> failures are different with or without ANGLE.

Per my test, Linux intel driver of Mesa 11.2.0 fails the fbomultisample.2/4/8
cases. if using angle, only fbomultisample.8 fails.
But the latest mesa(12.1.0) passes all cases regardless of angle. Probably we
can simply wait for the mesa driver fix.

Powered by Google App Engine
This is Rietveld 408576698